Jira (PUP-9963) The 'value' field of 'selboolean' should accept Booleans

25 views
Skip to first unread message

Trevor Vaughan (JIRA)

unread,
Aug 13, 2019, 9:51:04 AM8/13/19
to puppe...@googlegroups.com
Trevor Vaughan created an issue
 
Puppet / Improvement PUP-9963
The 'value' field of 'selboolean' should accept Booleans
Issue Type: Improvement Improvement
Affects Versions: PUP 6.7.2, PUP 5.5.16
Assignee: Unassigned
Components: Modules
Created: 2019/08/13 6:50 AM
Priority: Normal Normal
Reporter: Trevor Vaughan

Puppet Version: Any
Puppet Server Version: Any
OS Name/Version: Linux with SELinux

Presently, the selboolean native type accepts either on or off as valid entries for the value parameter.

Desired Behavior:

 

The value parameter should accept Boolean values since they will reduce the need for simple translation statements every time selboolean is used.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Jorie Tappa (JIRA)

unread,
Aug 19, 2019, 12:58:04 PM8/19/19
to puppe...@googlegroups.com
Jorie Tappa updated an issue
Change By: Jorie Tappa
Team: Night's Watch

Mihai Buzgau (JIRA)

unread,
Aug 20, 2019, 9:49:03 AM8/20/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - Triage

Gheorghe Popescu (JIRA)

unread,
Aug 21, 2019, 5:54:03 AM8/21/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Story Points: 3

Henrik Lindberg (JIRA)

unread,
Aug 21, 2019, 6:40:03 AM8/21/19
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-9963
 
Re: The 'value' field of 'selboolean' should accept Booleans

It would be reasonable to fix this by allowing `Boolean` to be constructed from "on", and "off" (since it already supports variations of true/false, yes/no strings).
Then, this can be implemented so that the selbolean accepts `Init[Boolean]` and calls `Boolean(val)` to create an actual boolean value.

Mihai Buzgau (JIRA)

unread,
Sep 4, 2019, 5:54:03 AM9/4/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
 
Change By: Mihai Buzgau
Sprint: PR NW - Triage 2019-09-18

Mihai Buzgau (JIRA)

unread,
Sep 4, 2019, 5:56:02 AM9/4/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW PR - 2019-09-18 Triage

Mihai Buzgau (JIRA)

unread,
Oct 16, 2019, 5:05:06 AM10/16/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - Triage , PR - Triage

Mihai Buzgau (JIRA)

unread,
Oct 30, 2019, 6:29:03 AM10/30/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - Triage, PR NW - Triage 2019-11-13

Ciprian Badescu (JIRA)

unread,
Oct 30, 2019, 10:00:12 AM10/30/19
to puppe...@googlegroups.com

Ciprian Badescu (JIRA)

unread,
Oct 30, 2019, 10:02:03 AM10/30/19
to puppe...@googlegroups.com
Ciprian Badescu assigned an issue to Ciprian Badescu
 
Change By: Ciprian Badescu
Assignee: Ciprian Badescu

Ciprian Badescu (JIRA)

unread,
Oct 31, 2019, 9:08:03 AM10/31/19
to puppe...@googlegroups.com
 
Re: The 'value' field of 'selboolean' should accept Booleans

Trevor Vaughan, is this ticket about the input accepted for `value` property or about how `value` property is handled internally in puppet?

Can you give an example of what you want to do and it is not working?

 

Trevor Vaughan (JIRA)

unread,
Nov 1, 2019, 9:29:02 AM11/1/19
to puppe...@googlegroups.com

Ciprian Badescu Honestly, I just wanted to be able to pass true or false instead of on and off to the value property.

Ciprian Badescu (JIRA)

unread,
Nov 4, 2019, 3:44:02 AM11/4/19
to puppe...@googlegroups.com

Trevor Vaughan, PR done

Ciprian Badescu (JIRA)

unread,
Nov 14, 2019, 10:07:06 AM11/14/19
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Change By: Ciprian Badescu
Fix Version/s: PUP 6.11.0

Heston Hoffman (JIRA)

unread,
Nov 17, 2019, 4:25:03 PM11/17/19
to puppe...@googlegroups.com
Heston Hoffman updated an issue
Change By: Heston Hoffman
Labels: resolved-issue-added

Dorin Pleava (JIRA)

unread,
Jan 8, 2020, 7:13:03 AM1/8/20
to puppe...@googlegroups.com
Dorin Pleava updated an issue
Change By: Dorin Pleava
Fix Version/s: PUP 6.4.5
Fix Version/s: PUP 5.5.18
Reply all
Reply to author
Forward
0 new messages