Jira (PDB-4479) Deactivate node commands sync after garbage collection

[Austin Blatt (JIRA)]

Austin Blatt created an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection Issue Type: Bug Assignee: Unassigned Created: 2019/08/12 3:13 PM Priority: Normal Reporter: Austin Blatt This is a bug in PE's HA sync. On the local PuppetDB, when a node is purged after a deactivate node command and then a garbage collection run after node-purge-ttl time has passed, the node is deleted. The remote PuppetDB also has that deactivated node present, but has not run garbage collection, when the local PuppetDB (that has just garbage collection the node) attempts to sync from the remote it will sync back the node it just garbage collected. This will result in a ping-pong effect and the node will never be purged from PuppetDB Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Nick Walker (JIRA)]

Nick Walker updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Walker Team: HA

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt This is a bug in PE pe-puppetdb 's HA sync.

On the local PuppetDB, when a node is purged after a deactivate node command and then a garbage collection run after node-purge-ttl time has passed, the node is deleted. The remote PuppetDB also has that deactivated node present, but has not run garbage collection, when the local PuppetDB (that has just garbage collection the node) attempts to sync from the remote it will sync back the node it just garbage collected. This will result in a ping-pong effect and the node will never be purged from PuppetDB

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Acceptance Criteria: Nodes that are garbage collected on one PuppetDB are * Does not re sync node deactivation commands that have a deactivated timestamp older than node - synced from the remote purge-ttl * Does not sync node data (agentless nodes 6 . 3.x+) that have a deactivated/expired timestamp older than node-purge-ttl

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection Change By: Austin Blatt

This is a bug in pe-puppetdb's HA sync because we only check the value of {{producer_timestamp}} and not the timestamps named {{deactivate}} and {{expired}} in the {{certnames}} table in the {{would_be_expired_locally?}} function of {{ . ../sync/core.clj}}

On the local PuppetDB, when a node is purged after a deactivate node command and then a garbage collection run after node-purge-ttl time has passed, the node is deleted. The remote PuppetDB also has that deactivated node present, but has not run garbage collection, when the local PuppetDB (that has just garbage collection the node) attempts to sync from the remote it will sync back the node it just garbage collected. This will result in a ping-pong effect and the node will never be purged from PuppetDB

Add Comment

[Nick Burgan (JIRA)]

Nick Burgan updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Burgan Release Notes: Bug Fix

Add Comment

[Nick Burgan (JIRA)]

Nick Burgan updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Burgan Story Points: 2

Add Comment

[Nick Burgan (JIRA)]

Nick Burgan updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Burgan Sprint: HA Team 2019-12-18

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Fix Version/s: PDB 6.3.7 Fix Version/s: PDB 5.2.12 Fix Version/s: PDB 6.7.4

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt assigned an issue to Austin Blatt

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Assignee: Austin Blatt

Add Comment

[Melissa Amos (JIRA)]

Melissa Amos commented on PDB-4479

Re: Deactivate node commands sync after garbage collection In discussion with Heston Hoffman, we agreed this should go in PDB release notes, if anywhere.

Add Comment

[Melissa Amos (JIRA)]

Melissa Amos updated an issue

PuppetDB / PDB-4479

Deactivate node commands sync after garbage collection

Change By: Melissa Amos Labels: docs_reviewed

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Fix Version/s: PDB 6.7.4

Fix Version/s: PDB 6.3.7 Fix Version/s: PDB 5.2.12

Add Comment

[Nick Burgan (JIRA)]

Nick Burgan updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Burgan Sprint: HA Team 2020-01-15 , HA Team 2020-01-29

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt assigned an issue to Unassigned

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Assignee: Austin Blatt

Add Comment

[Nick Burgan (JIRA)]

Nick Burgan updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Nick Burgan Sprint: HA Team 2020-01-15, HA Team 2020-01-29 , HA Team 2020-02-12

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt assigned an issue to Austin Blatt

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Assignee: Austin Blatt

Add Comment

[Joshua Partlow (JIRA)]

Joshua Partlow commented on PDB-4479

Re: Deactivate node commands sync after garbage collection Austin Blatt What build of PE did this land in? And what fix versions? 2019.y only? Has the main master pe integration ci run with it?

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt commented on PDB-4479

Re: Deactivate node commands sync after garbage collection

Joshua Partlow this landed in PuppetDB on all PE streams yesterday afternoon so I believe it's been tested overnight on 2018.x and master. Looks like a network issue stopped promotion to Kearney so I re-kicked that promotion.

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-4479

Deactivate node commands sync after garbage collection

Change By: Austin Blatt Fix Version/s: PDB 6.9.0 Fix Version/s: PDB 6.3.8 Fix Version/s: PDB 5.2.13

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Fix Version/s: PDB 6.3.8

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-4479 Deactivate node commands sync after garbage collection

Change By: Austin Blatt Release Notes Summary: Fixed an issue affecting PE installations where PuppetDB would fail to purge a deactivated node.

Add Comment