Jira (PUP-9943) User type has custom retrieve() with non-standard return values

0 views
Skip to first unread message

Sean Millichamp (JIRA)

unread,
Aug 8, 2019, 9:59:02 AM8/8/19
to puppe...@googlegroups.com
Sean Millichamp created an issue
 
Puppet / Bug PUP-9943
User type has custom retrieve() with non-standard return values
Issue Type: Bug Bug
Affects Versions: PUP 6.7.2, PUP 5.5.16
Assignee: Unassigned
Components: Types and Providers
Created: 2019/08/08 6:58 AM
Priority: Normal Normal
Reporter: Sean Millichamp

The core user type has a custom retrieve() method which returns a Hash that is inconsistent with the data type returned by the common method in Puppet::Type.retrieve(). As a result, mechanisms expecting to use retrieve() will have problems with user resources.

Here is the offending code in the user type: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/user.rb#L496-L513

I think it may be safe and desirable to just remove the user type's retrieve block and let the standard one take effect. The existing retrieve method seems to be 10+ years old and may just be an artifact of a much earlier time in Puppet's life.

Regardless if the method is needed or not, it should have a return value consistent with the expected return value from the standard Puppet::Type.retrieve() method.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Sean Millichamp (JIRA)

unread,
Aug 8, 2019, 11:11:03 AM8/8/19
to puppe...@googlegroups.com
Sean Millichamp commented on Bug PUP-9943
 
Re: User type has custom retrieve() with non-standard return values

As an additional note: It appears that the Puppet::Type.retrieve_resource() method was perhaps designed as a work-around to this particular problem. However, it is marked as a private API. https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type.rb#L1122-L1136

 

Sean Millichamp (JIRA)

unread,
Aug 8, 2019, 3:23:02 PM8/8/19
to puppe...@googlegroups.com

Jorie Tappa (JIRA)

unread,
Aug 12, 2019, 12:57:04 PM8/12/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Oct 30, 2019, 2:19:02 AM10/30/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Oct 30, 2019, 2:26:02 AM10/30/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Grooming Community PRs

Mihai Buzgau (JIRA)

unread,
Dec 4, 2019, 7:05:04 AM12/4/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: Community PRs PR - Triage

Mihai Buzgau (JIRA)

unread,
Dec 4, 2019, 7:05:05 AM12/4/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Team: Coremunity Night's Watch

Mihai Buzgau (JIRA)

unread,
Jan 22, 2020, 6:12:04 AM1/22/20
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Jan 22, 2020, 6:12:04 AM1/22/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR NW - Triage 2020-02-05

Dorin Pleava (JIRA)

unread,
Jan 28, 2020, 7:39:06 AM1/28/20
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Feb 5, 2020, 5:38:08 AM2/5/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-05 , NW - 2020-02-19

Mihai Buzgau (JIRA)

unread,
Feb 19, 2020, 6:18:16 AM2/19/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-05, NW - 2020-02-19 , NW - 2020-03-04

Mihai Buzgau (Jira)

unread,
Mar 5, 2020, 3:54:04 AM3/5/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-05, NW - 2020-02-19, NW - 2020-03-04 , NW - 2020-03-17
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Mar 18, 2020, 4:54:03 AM3/18/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-05, NW - 2020-02-19, NW - 2020-03-04, NW - 2020-03-17 , NW - 2020-04-01

Gabriel Nagy (Jira)

unread,
Apr 23, 2020, 8:21:03 AM4/23/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Apr 27, 2020, 8:36:03 AM4/27/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages