Jira (PUP-9942) no_proxy environment variable does not work

Change By:	Josh Cooper
Sprint:	Platform Core KANBAN

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 6:06:03 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper assigned an issue to Josh Cooper

Puppet /

Change By:	Josh Cooper
Assignee:	Josh Cooper

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 6:06:03 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper created an issue

Puppet /

Issue Type:	Bug
Assignee:	Unassigned
Created:	2019/08/07 3:05 PM
Priority:	Normal
Reporter:	Josh Cooper

Commit 90560edf0f43f5382bd539646988f7a96ea3809e for PUP-4020 added the ability to skip an http proxy if the host and port matched an entry in the NO_PROXY environment variable. However it didn't actually work because our connection factory passed the Site object instead of a String or URI.

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 6:07:02 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper

Commit 90560edf0f43f5382bd539646988f7a96ea3809e for PUP- 4020 4030 added the ability to skip an http proxy if the host and port matched an entry in the {{NO_PROXY}} environment variable. However it didn't actually work because our connection factory passed the {{Site}} object instead of a String or URI.

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 6:28:02 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper

Commit 90560edf0f43f5382bd539646988f7a96ea3809e for PUP-4030 added the ability to skip an http proxy if the host and port matched an entry in the {{NO_PROXY}} environment variable. However it didn't actually work because our connection factory passed the {{Site}} object instead of a String or URI. To reproduce specify an unused http proxy port and try to not use a proxy for the puppet server:

{noformat}
$ env NO_PROXY=$(bundle exec puppet config print server --section main) bundle exec puppet agent -t --http_proxy_host localhost --http_proxy_port 12345
Warning: Unable to fetch my node definition, but the agent run will continue:
Warning: Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345)
Info: Retrieving pluginfacts
Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Failed to generate additional resources using 'eval_generate': Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345)
Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Could not evaluate: Could not retrieve file metadata for puppet:///pluginfacts: Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345)
...
{noformat}

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 7:25:02 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Fix Version/s:	PUP 5.5.17

Josh Cooper (JIRA)

unread,

Aug 7, 2019, 7:27:03 PM8/7/19

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /