Jira (PUP-9962) stdlib : When ensure_resource() is used, it should correctly report duplicate resource declaration issues with more correct file and line numbers

Patrick Grant (JIRA)

unread,

Aug 13, 2019, 6:39:03 AM8/13/19

to puppe...@googlegroups.com

Patrick Grant moved an issue

Puppet /

PUP-9962

stdlib : When ensure_resource() is used, it should correctly report duplicate resource declaration issues with more correct file and line numbers

Change By:	Patrick Grant
Component/s:	stdlib
Key:	MODULES PUP - 9655 9962
Project:	Modules Puppet

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Norman Heaney (JIRA)

unread,

Aug 21, 2019, 3:18:03 AM8/21/19

to puppe...@googlegroups.com

Norman Heaney commented on

PUP-9962

Re: stdlib : When ensure_resource() is used, it should correctly report duplicate resource declaration issues with more correct file and line numbers

Hi Gareth

Just following up on this issue, any other comments? As Florin has verified the root causes is not within the stdlib module.

I'm not sure which team is best placed to close out on this ticket

thanks
norman
]

Add Comment

Henrik Lindberg (JIRA)

unread,

Aug 21, 2019, 5:54:05 AM8/21/19

to puppe...@googlegroups.com

Henrik Lindberg commented on

PUP-9962

Re: stdlib : When ensure_resource() is used, it should correctly report duplicate resource declaration issues with more correct file and line numbers

Seems like `ensure_resource` should set file/line information - it does not do that now so the created resources simply lack location information.

Could be fixed by reimplementing the function as a 4x function (while not strictly required though) and using the `PuppetStack` to get the calling file/line (caller of `ensure_resource`) and propagating that information onwards should ensure that the conflicting resources have this information.

Have not actually tested if that would fix this, but I think it is a good bet.