Jira (BOLT-1451) Automatically call apply_prep before `resources` step in YAML plans

16 views
Skip to first unread message

Nick Lewis (JIRA)

unread,
Jul 2, 2019, 12:30:03 PM7/2/19
to puppe...@googlegroups.com
Nick Lewis created an issue
 
Puppet Task Runner / Improvement BOLT-1451
Automatically call apply_prep before `resources` step in YAML plans
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/07/02 9:29 AM
Priority: Normal Normal
Reporter: Nick Lewis

Currently, if the user needs to apply_prep before a resources step in a YAML plan, they need to have an eval step that calls it. This is a bit unnatural in a YAML plan and requires some more knowledge before successfully using the resources step.

We should figure out some way to automatically call apply_prep on the user's behalf, potentially either the first time a resources step is encountered or every time a resources step is encountered. We could also add a parameter to the resources step to toggle whether or not to apply_prep beforehand.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Lucy Wyman (JIRA)

unread,
Aug 6, 2019, 12:32:04 PM8/6/19
to puppe...@googlegroups.com

Lucy Wyman (JIRA)

unread,
Aug 6, 2019, 12:32:04 PM8/6/19
to puppe...@googlegroups.com
Lucy Wyman updated an issue
Change By: Lucy Wyman
Sprint: Bolt Ready for Grooming Kanban

Cas Donoghue (JIRA)

unread,
Aug 6, 2019, 2:55:03 PM8/6/19
to puppe...@googlegroups.com

Cas Donoghue (JIRA)

unread,
Aug 6, 2019, 2:57:03 PM8/6/19
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Currently, if the user needs to {{apply_prep}} before a {{resources}} step in a YAML plan, they need to have an {{eval}} step that calls it. This is a bit unnatural in a YAML plan and requires some more knowledge before successfully using the {{resources}} step.

We should figure out some way to automatically call {{apply_prep}} on the user's behalf, potentially either the first time a resources step is encountered or every time a resources step is encountered. We could also add a parameter to the resources step to toggle whether or not to apply_prep beforehand.


UPDATE:
Ideally we would be able to track whether apply_prep is necessary for each time. As a starting point we will just implement the easier solution which appears to be to just call apply_prep each time. As we learn more about how to apply_prep smarter we can improve.

Cas Donoghue (JIRA)

unread,
Aug 7, 2019, 1:57:03 PM8/7/19
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Release Notes Summary: When using a {{resources}} step in a Yaml plan, {{apply_prep}} is automatically performed on the targets for that step.

Cas Donoghue (JIRA)

unread,
Aug 8, 2019, 10:08:03 AM8/8/19
to puppe...@googlegroups.com

Chris Cowell (JIRA)

unread,
Aug 9, 2019, 1:31:03 AM8/9/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages