Jira (FACT-1930) Relax ruby facter ffi constraint for ruby 2.6

13 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Jun 13, 2019, 5:18:04 PM6/13/19
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Improvement FACT-1930
Relax ruby facter ffi constraint for ruby 2.6
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/06/13 2:17 PM
Priority: Normal Normal
Reporter: Josh Cooper

If you try to bundle install puppet on ruby 2.6 on Windows, it will fail because the windows facter gem is constrained to:

if RUBY_VERSION < '2.0.0'
 
  gem 'ffi', '<= 1.9.14', :require => false
 
else
 
  gem 'ffi', '~> 1.9.18', :require => false
 
end

But ffi 1.9.x doesn't support ruby 2.6, as it was added in 1.10.0.

We should relax facter's ffi dependency. The safest thing is to only relax the ffi dependency when running on ruby 2.6 or greater:

if RUBY_VERSION.to_f < 2.0
 
  gem 'ffi', '<= 1.9.14', :require => false
 
elsif RUBY_VERSION.to_f < 2.6
 
  gem 'ffi', '~> 1.9.18', :require => false
 
else
 
  gem 'ffi', '~> 1.10.0', :require => false
 
end

/cc Ethan Brown, Mihai Buzgau
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Jun 13, 2019, 5:20:03 PM6/13/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 2.5.2

Josh Cooper (JIRA)

unread,
Jun 13, 2019, 5:20:04 PM6/13/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Puppet Romania

Mihai Buzgau (JIRA)

unread,
Jun 14, 2019, 4:08:03 AM6/14/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - Triage

Gheorghe Popescu (JIRA)

unread,
Jun 26, 2019, 4:48:03 AM6/26/19
to puppe...@googlegroups.com
Gheorghe Popescu commented on Improvement FACT-1930
 
Re: Relax ruby facter ffi constraint for ruby 2.6

PR was merged. we'll try to release a new gem of facter this sprint

Sebastian Miclea (JIRA)

unread,
Jun 26, 2019, 4:48:03 AM6/26/19
to puppe...@googlegroups.com
Sebastian Miclea updated an issue
 
Change By: Sebastian Miclea
Sprint: PR - Triage 2019-07-10

Sebastian Miclea (JIRA)

unread,
Jun 26, 2019, 4:48:03 AM6/26/19
to puppe...@googlegroups.com
Sebastian Miclea updated an issue
Change By: Sebastian Miclea
Story Points: 2

Mihai Buzgau (JIRA)

unread,
Jul 10, 2019, 4:11:11 AM7/10/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-07-10 , PR - 2019-07-23
Reply all
Reply to author
Forward
0 new messages