Jira (PUP-9749) puppet generate types should be run when the puppetserver is upgraded

9 views
Skip to first unread message

Trevor Vaughan (JIRA)

unread,
Jun 12, 2019, 12:02:09 PM6/12/19
to puppe...@googlegroups.com
Trevor Vaughan created an issue
 
Puppet / Bug PUP-9749
puppet generate types should be run when the puppetserver is upgraded
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/06/12 9:01 AM
Priority: Normal Normal
Reporter: Trevor Vaughan

When the puppetserver is upgraded, existing artifacts generated by puppet generate types may no longer work and so it needs to be re-run automatically on upgrade.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Jun 13, 2019, 7:42:03 PM6/13/19
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-9749
 
Re: puppet generate types should be run when the puppetserver is upgraded

I wouldn't expect that to be necessary. Is there a specific module that fails when the server is updated? /cc Henrik Lindberg

Trevor Vaughan (JIRA)

unread,
Jun 13, 2019, 8:52:03 PM6/13/19
to puppe...@googlegroups.com

Josh Cooper I didn't either but it definitely was.

It was with a stack of SIMP modules, didn't debug past the fact that rerunning puppet generate types fixed everything.

Henrik Lindberg (JIRA)

unread,
Jun 14, 2019, 2:12:03 AM6/14/19
to puppe...@googlegroups.com

In general it there is no need to regenerate.
However, could have been that earlier version of generate did output something that was not quite right... don't remember exactly, but think we have fixed one such issue.

Can an upgrade of server mean that there will also be different versions of modules? If so, generate needs to run to pick up those changes.

Trevor Vaughan (JIRA)

unread,
Jun 17, 2019, 4:57:03 PM6/17/19
to puppe...@googlegroups.com

Given the comment from Henrik Lindberg, it would seem that the safe thing to do would be to run it and give people the ability to opt-out.

Reply all
Reply to author
Forward
0 new messages