Jira (BOLT-1382) wait_until_available() incorrect results using Orchestrator

[Reid Vandewiele (JIRA)]

Reid Vandewiele created an issue

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator Issue Type: Bug Assignee: Unassigned Created: 2019/06/11 1:43 PM Priority: Normal Reporter: Reid Vandewiele The wait_until_available() function seems to all-or-nothing succeed/fail when using --transport pcp. See below for an example. The same test plan will return the expected results when run over ssh. [root@pe-xl-core-0 bolt-project]# cat site-modules/util/plans/test.pp plan util::test ( TargetSpec $nodes, ) { $connection_results = wait_until_available(get_targets($nodes), wait_time => 0, _catch_errors => true, )   return({ 'ok_set' => $connection_results.ok_set.names, 'error_set' => $connection_results.error_set.names, }) } [root@pe-xl-core-0 bolt-project]# bolt plan run util::test --targets pe-xl-core-0.dev36.puppet.vm,pe-xl-core-1.dev36.puppet.vm Starting: plan util::test Starting: wait until available on pe-xl-core-0.dev36.puppet.vm, pe-xl-core-1.dev36.puppet.vm Finished: wait until available with 0 failures in 0.28 sec Finished: plan util::test in 0.29 sec { "ok_set": [ "pe-xl-core-0.dev36.puppet.vm", "pe-xl-core-1.dev36.puppet.vm" ], "error_set": [   ] } [root@pe-xl-core-0 bolt-project]# bolt plan run util::test --targets pe-xl-core-0.dev36.puppet.vm,pe-xl-core-1.dev36.puppet.vm,badname Starting: plan util::test Starting: wait until available on pe-xl-core-0.dev36.puppet.vm, pe-xl-core-1.dev36.puppet.vm, badname Finished: wait until available with 3 failures in 0.23 sec Finished: plan util::test in 0.25 sec { "ok_set": [   ], "error_set": [ "pe-xl-core-0.dev36.puppet.vm", "pe-xl-core-1.dev36.puppet.vm", "badname" ] } [root@pe-xl-core-0 bolt-project]# Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Reid Vandewiele (JIRA)]

Reid Vandewiele commented on BOLT-1382

Re: wait_until_available() incorrect results using Orchestrator It kinda looks like we operate in batches, and don't have any concept of some targets in a batch being unavailable while others in the same batch are. https://github.com/puppetlabs/bolt/blob/377350ecf2a9e193b1013fb05554cd12e7418245/lib/bolt/executor.rb#L284-L300

Add Comment

[Reid Vandewiele (JIRA)]

Reid Vandewiele commented on BOLT-1382

Re: wait_until_available() incorrect results using Orchestrator

Filed a starter PR at https://github.com/puppetlabs/bolt/pull/1031.

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

Puppet Task Runner / BOLT-1382

wait_until_available() incorrect results using Orchestrator

Change By: David Kramer Sprint: Bolt Kanban

Add Comment

[David Kramer (JIRA)]

David Kramer assigned an issue to Lucy Wyman

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator

Change By: David Kramer Assignee: Lucy Wyman

Add Comment

[Cas Donoghue (JIRA)]

Cas Donoghue assigned an issue to Cas Donoghue

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator

Change By: Cas Donoghue Assignee: Lucy Wyman Cas Donoghue

Add Comment

[Cas Donoghue (JIRA)]

Cas Donoghue updated an issue

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator

Change By: Cas Donoghue Release Notes Summary: The plan function {{wait_until_available}} has been updated such that only targets which cannot be reached are returned as an error result when using the {{PCP}} transport. Release Notes: Bug Fix

Add Comment

[Cas Donoghue (JIRA)]

Cas Donoghue updated an issue

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator

Change By: Cas Donoghue Fix Version/s: BOLT Next

Add Comment

[Melissa Amos (JIRA)]

Melissa Amos updated an issue

Puppet Task Runner / BOLT-1382 wait_until_available() incorrect results using Orchestrator

Change By: Melissa Amos Labels: docs_reviewed

Add Comment

[Melissa Amos (JIRA)]

Melissa Amos commented on BOLT-1382

Re: wait_until_available() incorrect results using Orchestrator Docs: https://puppet.com/docs/bolt/latest/bolt_resolved_issues.html#the-wait-until-available-function-returned-incorrect-results-using-orchestrator-1-23-0

Add Comment