Jira (PUP-9747) Bolt provides too many attributes to remote transports

0 views
Skip to first unread message

David Schmitt (JIRA)

unread,
Jun 11, 2019, 11:26:03 AM6/11/19
to puppe...@googlegroups.com
David Schmitt created an issue
 
Puppet / Bug PUP-9747
Bolt provides too many attributes to remote transports
Issue Type: Bug Bug
Affects Versions: PUP 6.4.2
Assignee: David Schmitt
Created: 2019/06/11 8:25 AM
Priority: Critical Critical
Reporter: David Schmitt

From https://groups.google.com/a/puppet.com/forum/#!topic/team-network-automation/bEiFEudGyrc and private slack convo with Alex Dreyer

Bolt provides a lot of attributes to remote transports that the Resource API is not prepared to handle. Change the resource api transport layer to silently discard any attributes from the list of "default" attributes bolt provides if the transport is not prepared to receive them.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

David Schmitt (JIRA)

unread,
Jun 11, 2019, 11:41:03 AM6/11/19
to puppe...@googlegroups.com
David Schmitt updated an issue
Change By: David Schmitt
From https://groups.google.com/a/puppet.com/forum/#!topic/team-network-automation/bEiFEudGyrc and private slack convo with [~alex]

Bolt provides a lot of attributes to remote transports that the Resource API is not prepared to handle. Change the resource api transport layer to
silently discard any attributes from the list of "default" attributes bolt provides passed in as connection_info if they do not match up the transport is not prepared to receive them 's schema .

* For each discarded attribute that matches the list in https://github.com/puppetlabs/puppet-resource_api#usable-within-the-schema emit a info message.
* For each discarded attribute that matches the list in https://github.com/puppetlabs/puppet-resource_api#non-usable-within-the-schema emit a debug message.
* For every other discarded attribute emit a warning message.

Alex Dreyer (JIRA)

unread,
Jun 11, 2019, 11:59:03 AM6/11/19
to puppe...@googlegroups.com
Alex Dreyer updated an issue
Change By: Alex Dreyer
Bolt provides a lot of attributes to remote transports that the Resource API is not prepared to handle. Change the resource api transport layer to silently discard any attributes passed in as connection_info from the list of "default" attributes bolt provides if they do not match up the transport is not prepared to receive them.


The following keys come from uri parsing in bolt and are likely to be used in transport schema
's schema but may not always .

* For each discarded attribute that matches the list
they should be filtered out when not present in the schema(from https://github.com/puppetlabs/puppet-resource_api#usable-within-the-schema emit with password added.):

uri - Use when you need to specify
a info message specific URL to connect to . All of the following keys will be computed from the uri if possible. In the future more url parts may be computed from the URI as well.
* For each discarded attribute that matches host - Use to specify and IP or address to connect to.
port - The port
the list in transport should connect to.
protocol - Use to specify which protocol the transport should use for example http,
https ://github , ssh or tcp
user - The user the transport should connect as
. com/puppetlabs/puppet
password
- resource_api#non the password to use when connecting

The following keys are meta keys bolt uses and should not be included in transport schemas
run
- usable on - within This is used by bolt to determine which target to proxy to. Transports should not rely on this key.
remote
- the transport - schema emit a debug message This is used to determine which transport to load . It should always be the transport class name "declassified".
remote- * For every other discarded attribute emit a warning message Any key starting with remote- is reserved for future use .

These keys are reserved for future URI parsing use but not currenlty exposed.
path - reserved as a uri part
query - reserved as a uri part

Reply all
Reply to author
Forward
0 new messages