Jira (PUP-9744) Create acceptance test for PUP-9047

David Schmitt (JIRA)

unread,

Jun 10, 2019, 10:01:03 AM6/10/19

to puppe...@googlegroups.com

David Schmitt created an issue

Puppet /

PUP-9744

Create acceptance test for PUP-9047

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2019/06/10 7:00 AM
Priority:	Normal
Reporter:	David Schmitt

https://github.com/puppetlabs/puppet/pull/7550 showed that the current acceptance test in https://github.com/puppetlabs/puppet/blob/d9523b596c5c09ac3858029ecd628174f752552b/acceptance/tests/puppet_device_test.rb is not sufficient to catch issues like ~~PUP-9047~~.

To make sure this does not regress again, modify the existing test to also check for the condition described in ~~PUP-9047~~ - the ticket has a simple repro step.

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Josh Cooper (JIRA)

unread,

Jun 10, 2019, 1:35:04 PM6/10/19

to puppe...@googlegroups.com

Josh Cooper commented on

PUP-9744

Re: Create acceptance test for PUP-9047

it is also possible to create an rspec integration test like we have for puppet apply. I prefer that over beaker acceptance, because of the faster feedback, but up to you which way to proceed.