Jira (PUP-9725) Remediate acceptance tests that have been audited to be moved to unit/integration suites

[John Duarte (JIRA)]

John Duarte created an issue

Puppet / PUP-9725 Remediate acceptance tests that have been audited to be moved to unit/integration suites Issue Type: Task Assignee: Unassigned Created: 2019/05/30 11:48 AM Priority: Normal Reporter: John Duarte As a puppet tester I want the acceptance test suite to mitigate risk commensurate to its cost of execution So that I can get test feedback faster Without increasing my product risk Acceptance tests are expensive. The puppet acceptance test suite was audited in July 2017 to evaluate the type of testing needed to mitigate the risk each test covers. Tests deemed as being eligible for moving to the unit or integration suites via audit:unit beaker tags should be removed from the acceptance test suite. These should be verified to be covered by existing unit/integration tests, or tests should be written in those suites to cover the risks addressed by the previous acceptance tests. The list for these tests are as follows: acceptance/tests/apply/classes/should_include_resources_from_class.rb acceptance/tests/apply/classes/parameterized_classes.rb acceptance/tests/apply/classes/should_allow_param_override.rb acceptance/tests/apply/classes/should_not_auto_include_resources_from_class.rb acceptance/tests/apply/classes/should_allow_param_undef_override.rb acceptance/tests/environment/enc_nonexistent_directory_environment.rb acceptance/tests/environment/environment_scenario-bad.rb acceptance/tests/face/parser_validate.rb acceptance/tests/language/resource_refs_with_nested_arrays.rb acceptance/tests/language/return.rb acceptance/tests/loader/func4x_loadable_from_modules.rb acceptance/tests/parser_functions/no_exception_in_reduce_with_bignum.rb acceptance/tests/puppet_apply_a_file_should_create_a_file_and_report_the_md5.rb acceptance/tests/puppet_apply_basics.rb acceptance/tests/resource/group/should_not_destoy_unexisting.rb acceptance/tests/resource/group/should_create.rb acceptance/tests/resource/group/should_modify_gid.rb acceptance/tests/resource/group/should_not_create_existing.rb acceptance/tests/resource/group/should_query.rb acceptance/tests/resource/group/should_destroy.rb acceptance/tests/resource/service/service_enable_linux.rb acceptance/tests/resource/service/ticket_5024_systemd_enabling_masked_service.rb acceptance/tests/resource/service/launchd_provider.rb acceptance/tests/resource/service/AIX_service_provider.rb acceptance/tests/resource/service/init_on_systemd.rb acceptance/tests/resource/service/smf_basic_tests.rb acceptance/tests/resource/package/yum.rb acceptance/tests/resource/package/ips/should_create.rb acceptance/tests/resource/package/ips/should_be_holdable.rb acceptance/tests/resource/package/ips/should_be_idempotent.rb acceptance/tests/resource/package/ips/should_remove.rb acceptance/tests/resource/package/ips/should_query.rb acceptance/tests/resource/package/ips/should_be_versionable.rb acceptance/tests/resource/package/ips/basic_tests.rb acceptance/tests/resource/package/ips/should_be_updatable.rb acceptance/tests/resource/package/does_not_exist.rb acceptance/tests/server_list_setting.rb acceptance/tests/ticket_3656_requiring_multiple_resources.rb acceptance/tests/ticket_5592_hiera_lookup_when_param_undef.rb Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[John Duarte (JIRA)]

John Duarte updated an issue

Puppet / PUP-9725 Remediate acceptance tests that have been audited to be moved to unit/integration suites

Change By: John Duarte Acceptance Criteria: *Given* a checkout of puppet *When* I run puppet tests not requiring the management of a master *Then* the {{with_puppet_running_on}} is not used in these tests.

Add Comment

[John Duarte (JIRA)]

John Duarte commented on PUP-9725

Re: Remediate acceptance tests that have been audited to be moved to unit/integration suites Of the above list, only the following have a risk tag of "audit:high". This ticket should be re-scoped to only include the tests below.

acceptance/tests/apply/classes/should_include_resources_from_class.rb acceptance/tests/apply/classes/parameterized_classes.rb acceptance/tests/apply/classes/should_allow_param_override.rb acceptance/tests/apply/classes/should_not_auto_include_resources_from_class.rb acceptance/tests/apply/classes/should_allow_param_undef_override.rb

acceptance/tests/language/resource_refs_with_nested_arrays.rb

acceptance/tests/resource/group/should_not_destoy_unexisting.rb acceptance/tests/resource/group/should_create.rb acceptance/tests/resource/group/should_modify_gid.rb acceptance/tests/resource/group/should_not_create_existing.rb acceptance/tests/resource/group/should_query.rb acceptance/tests/resource/group/should_destroy.rb

acceptance/tests/ticket_3656_requiring_multiple_resources.rb

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-9725

Re: Remediate acceptance tests that have been audited to be moved to unit/integration suites

We're in a "good enough" state now so I'm going to close this.

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)