Jira (BOLT-1299) YAML plan converter wraps single-line evals in with() if they end with a newline

0 views
Skip to first unread message

Nick Lewis (JIRA)

unread,
May 9, 2019, 1:41:02 PM5/9/19
to puppe...@googlegroups.com
Nick Lewis created an issue
 
Puppet Task Runner / Bug BOLT-1299
YAML plan converter wraps single-line evals in with() if they end with a newline
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/05/09 10:40 AM
Priority: Normal Normal
Reporter: Nick Lewis

The multi-line string formats in YAML (> and |) add a newline to the end of the string, regardless of whether it's a single line or multiple lines. That causes the plan converter to treat a single line eval as though it were multiple lines, and wrap it in with() unnecessarily.

This detection should check for whether the string actually contains multiple lines, not just whether it ends in a newline character.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Nick Lewis (JIRA)

unread,
May 9, 2019, 1:42:02 PM5/9/19
to puppe...@googlegroups.com

Nick Lewis (JIRA)

unread,
May 9, 2019, 1:42:02 PM5/9/19
to puppe...@googlegroups.com

Nick Lewis (JIRA)

unread,
May 9, 2019, 1:42:03 PM5/9/19
to puppe...@googlegroups.com

Nick Lewis (JIRA)

unread,
May 9, 2019, 1:43:06 PM5/9/19
to puppe...@googlegroups.com
Nick Lewis updated an issue
Change By: Nick Lewis
Release Notes Summary: {{bolt plan convert}} no longer wraps single-line eval steps in a {{with()}} statement unnecessarily.

Cas Donoghue (JIRA)

unread,
May 10, 2019, 1:22:04 PM5/10/19
to puppe...@googlegroups.com

Melissa Amos (JIRA)

unread,
May 13, 2019, 4:47:03 PM5/13/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages