Jira (FACT-1921) Facter java class incorrectly using "FACTERDIR" environment variable

[Thomas Montague (JIRA)]

Thomas Montague created an issue

Facter / FACT-1921 Facter java class incorrectly using "FACTERDIR" environment variable Issue Type: Bug Affects Versions: FACT 3.13.1, FACT 3.13.0, FACT 3.12.4, FACT 3.12.3, FACT 3.12.2, FACT 3.12.1, FACT 3.12.0, FACT 3.11.8, FACT 3.11.7, FACT 3.11.6, FACT 3.11.5, FACT 3.11.4, FACT 3.11.3, FACT 3.11.2, FACT 3.11.1, FACT 3.11.0, FACT 3.10.0, FACT 3.9.6, FACT 3.9.5, FACT 3.9.4, FACT 3.9.3, FACT 3.9.2, FACT 3.9.0, FACT 3.6.10, FACT 3.6.9, FACT 3.6.8, FACT 3.6.7, FACT 3.6.6, FACT 3.6.5, FACT 3.6.4, FACT 3.6.3, FACT 3.6.2, FACT 3.6.1, FACT 3.6.0, FACT 3.y Assignee: Unassigned Created: 2019/05/07 1:29 PM Labels: facter java Priority: Normal Reporter: Thomas Montague The [Facter java shim|https://github.com/puppetlabs/facter/blob/master/lib/Facter.java.in#L14] for jruby incorrectly uses the "FACTERDIR" environment variable as it includes the "${LIBFACTER_INSTALL_DESTINATION}" in the expected value for the variable. This is different from the [facter.rb implementation|https://github.com/puppetlabs/facter/blob/master/lib/facter.rb.in#L34] which defaults to a relative path to "${CMAKE_INSTALL_PREFIX}" and the "${LIBFACTER_INSTALL_DESTINATION}" string is appended to it for the location of "libfacter.so".     Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Thomas Montague (JIRA)]

Thomas Montague updated an issue

Facter / FACT-1921 Facter java class incorrectly using "FACTERDIR" environment variable

Change By: Thomas Montague

The [Facter java shim| [ https://github.com/puppetlabs/facter/blob/master/lib/Facter.java.in#L14] ] for jruby incorrectly uses the "FACTERDIR" environment variable as it includes the "${LIBFACTER_INSTALL_DESTINATION}" in the expected value for the variable. This is different from the [facter.rb implementation| [ https://github.com/puppetlabs/facter/blob/master/lib/facter.rb.in#L34] ] which defaults to a relative path to "${CMAKE_INSTALL_PREFIX}" and the "${LIBFACTER_INSTALL_DESTINATION}" string is appended to it for the location of "libfacter.so".     Add Comment

[Thomas Montague (JIRA)]

Thomas Montague commented on FACT-1921

Re: Facter java class incorrectly using "FACTERDIR" environment variable PR with fix: https://github.com/puppetlabs/facter/pull/1777

Add Comment

[Michael Smith (JIRA)]

Michael Smith updated an issue

Facter / FACT-1921

Facter java class incorrectly using "FACTERDIR" environment variable

Change By: Michael Smith Fix Version/s: FACT 3.y

Add Comment

[Mihai Buzgau (JIRA)]

Mihai Buzgau commented on FACT-1921

Re: Facter java class incorrectly using "FACTERDIR" environment variable Hi Thomas Montague looks like the PR for this ticket: https://github.com/puppetlabs/facter/pull/1785 got merged. Can this ticket be closed? Thank you for your contribution!

Add Comment

[Thomas Montague (JIRA)]

Thomas Montague commented on FACT-1921

Re: Facter java class incorrectly using "FACTERDIR" environment variable

Yup, ticket can be closed.

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on FACT-1921

Re: Facter java class incorrectly using "FACTERDIR" environment variable

Mihai Buzgau, the docs note doesn't tell me anything about what behavior users might have encountered or what this changes for them. Can you tell me what users need to know about this change, please?

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Facter / FACT-1921

Facter java class incorrectly using "FACTERDIR" environment variable

Change By: Jean Bond Release Notes: Bug Fix Not Needed

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on FACT-1921

Re: Facter java class incorrectly using "FACTERDIR" environment variable Thank you for confirming, Mihai Buzgau!

Add Comment