Jira (PUP-9691) Puppet pidlock incorrectly clears lock when running under bundler

18 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
May 3, 2019, 7:38:03 PM5/3/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Task PUP-9691
Puppet pidlock incorrectly clears lock when running under bundler
Change By: Josh Cooper
Team: Coremunity
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
May 3, 2019, 7:38:03 PM5/3/19
to puppe...@googlegroups.com
Josh Cooper created an issue
Issue Type: Task Task
Assignee: Unassigned
Created: 2019/05/03 4:37 PM
Priority: Normal Normal
Reporter: Josh Cooper

When running puppet in bundler, puppet will take ownership of its pidfile even if another puppet process is still running. It's because ps -p <pid> -o comm= returns the entire command line instead of just the process name:

$ ps -p 33239 -o comm=
 
/Users/josh/work/puppet/.bundle/ruby/2.5.0/bin/puppet agent --no-daemonize --runinterval 15s --certname wtf18 -v

The behavior seems to be ruby or platform specific. On redhat with ruby 2.3:

root@k1zm807wxji34df:~# ps -p 17196 -o comm=
 
ruby2.3
 
root@k1zm807wxji34df:~# ps -p 17196 -o args=
 
ruby2.3 /root/puppet/.bundle/ruby/2.3.0/bin/puppet agent --no-daemonize -v

When running puppet from a package, the process name is just puppet

[root@dp4uykbg81px49u ~]# ps -p `cat /var/run/puppetlabs/agent.pid` -o comm=
 
puppet

This regression was introduced in PUP-9247.

Josh Cooper (JIRA)

unread,
May 17, 2019, 12:17:03 PM5/17/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Puppet Romania

Josh Cooper (JIRA)

unread,
May 17, 2019, 12:17:04 PM5/17/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 5.5.z

Oana Tanasoiu (JIRA)

unread,
May 17, 2019, 12:23:03 PM5/17/19
to puppe...@googlegroups.com
Oana Tanasoiu assigned an issue to Oana Tanasoiu
Change By: Oana Tanasoiu
Assignee: Oana Tanasoiu

Oana Tanasoiu (JIRA)

unread,
May 20, 2019, 3:01:02 AM5/20/19
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Change By: Oana Tanasoiu
Sprint: PR - 2019-05-29

Mihai Buzgau (JIRA)

unread,
May 29, 2019, 5:22:09 AM5/29/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-05-29 , PR - 2019-06-12

Josh Cooper (JIRA)

unread,
Jun 11, 2019, 2:57:04 PM6/11/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Jun 11, 2019, 2:58:02 PM6/11/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 5.5.z
Fix Version/s: PUP 6.5.0
Fix Version/s: PUP 6.4.3
Fix Version/s: PUP 6.0.10
Fix Version/s: PUP 5.5.15

Mihai Buzgau (JIRA)

unread,
Jun 12, 2019, 4:21:10 AM6/12/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-05-29, PR - 2019-06-12 , PR - 2019-06-25

Oana Tanasoiu (JIRA)

unread,
Jun 13, 2019, 3:08:03 AM6/13/19
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Change By: Oana Tanasoiu
Fix Version/s: PUP 6.5.0

Octavian Larion (JIRA)

unread,
Jun 26, 2019, 9:07:03 AM6/26/19
to puppe...@googlegroups.com
Octavian Larion updated an issue
Change By: Octavian Larion
Fix Version/s: PUP 6.6.0
Reply all
Reply to author
Forward
0 new messages