Jira (FACT-1918) Facter is pinned to ruby version 2.1.7

0 views
Skip to first unread message

Corey Osman (JIRA)

unread,
May 2, 2019, 8:17:03 PM5/2/19
to puppe...@googlegroups.com
Corey Osman created an issue
 
Facter / Bug FACT-1918
Facter is pinned to ruby version 2.1.7
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/05/02 5:16 PM
Priority: Normal Normal
Reporter: Corey Osman

The facter gemspec is pinned to ruby 2.1.7 which is causing gem installation errors.

 

https://github.com/puppetlabs/facter/blob/master/lib/gemspec.in#L19

 

 

facter-3.11.8 requires ruby version ~> 2.1.7, which is incompatible with the current version, ruby 2.4.5p335

 

Steps to reproduce:

  1. Install the puppet-agent  (any version will work)
  2. Install pdk the gem (/opt/puppetlabs/puppet/bin/gem install pdk)
  3. Create a new module using the pdk (pdk new module test)
  4. cd test && pdk unit test 

The failure should occur as it tries to load the facter gem using the specification. 

 

Workaround

Remove the patch version from the 2.1.7 in the gemspec for post install issues

 

Gem::Specification.new do |s|
  s.name = "facter"
  version = "3.11.8"
  mdata = version.match(/(\d+\.\d+\.\d+)/)
  s.version = mdata ? mdata[1] : version  s.required_rubygems_version = Gem::Requirement.new(">= 0")
  s.authors = ["Puppet Labs"]
  s.date = "2015-10-22"
  s.description = "You can prove anything with facts!"
  s.email = "in...@puppetlabs.com"
  s.files = ["bin/facter"]
  s.homepage = "https://puppetlabs.com"
  s.require_paths = ["lib"]
  s.summary = "Facter, a system inventory tool"
  s.specification_version = 3
  s.required_ruby_version = '~> 2.1'  # <----- change from 2.1.7 to 2.1
end

 

Otherwise this would need to be fixed permanently here :

https://github.com/puppetlabs/facter/blob/master/lib/gemspec.in#L19 or possibly elsewhere in the code during the compilation process that produces the gemspec file.

 

Note: this is somewhat related to https://tickets.puppetlabs.com/browse/PA-2670 in that you may have to fix that issue as well.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Morgan Rhodes (JIRA)

unread,
May 9, 2019, 6:51:03 PM5/9/19
to puppe...@googlegroups.com
Morgan Rhodes assigned an issue to Morgan Rhodes
Change By: Morgan Rhodes
Assignee: Morgan Rhodes

Morgan Rhodes (JIRA)

unread,
May 9, 2019, 6:52:04 PM5/9/19
to puppe...@googlegroups.com

Morgan Rhodes (JIRA)

unread,
May 9, 2019, 6:52:04 PM5/9/19
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
 
Change By: Morgan Rhodes
Team: Release Engineering
Sprint: Release Engineering Kanban

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:07:02 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.13.z
Fix Version/s: FACT 3.12.z
Fix Version/s: FACT 3.11.z

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:13:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Release Notes: Not Needed

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:14:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Release Notes: Not Needed Bug Fix

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:15:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Release Notes Summary: The facter gemspec was pinned to ruby 2.1.7 which is causing gem installation errors.
Changed the pinned version to 2.1

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:37:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.13.z
Fix Version/s: FACT 3.12.z
Fix Version/s: FACT 3.11.z
Fix Version/s: FACT 3.13.3
Fix Version/s: FACT 3.12.5
Fix Version/s: FACT 3.11.9

Jean Bond (JIRA)

unread,
Jul 15, 2019, 4:28:03 PM7/15/19
to puppe...@googlegroups.com
Jean Bond updated an issue
Change By: Jean Bond
Labels: resolved-issue-added
Reply all
Reply to author
Forward
0 new messages