Jira (PUP-9689) String to integer conversion fails

11 views
Skip to first unread message

Nick Walker (JIRA)

unread,
Apr 30, 2019, 3:02:02 PM4/30/19
to puppe...@googlegroups.com
Nick Walker moved an issue
 
Puppet / Bug PUP-9689
String to integer conversion fails
Change By: Nick Walker
Affects Version/s: PE 2018.1.7
Affects Version/s: PE 2018.1.5
Key: ENTERPRISE PUP - 1254 9689
Project: Puppet Enterprise
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
May 1, 2019, 4:12:03 AM5/1/19
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-9689
 
Re: String to integer conversion fails

The problem is that the Integer.new function dispatcher requires the input string to be a well formed octal, decimal, or hexadecimal string to accept it as an input parameter. It should not require that when radix is given. I think the solution is to have a second dispatcher that allows any string - that will work since it is not trying to deduce radix from that value - and will subsequently fail if the string is not acceptable for the given radix.

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 7:26:04 AM5/3/19
to puppe...@googlegroups.com
Henrik Lindberg assigned an issue to Henrik Lindberg
 
Change By: Henrik Lindberg
Assignee: Henrik Lindberg

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 7:26:04 AM5/3/19
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 5.5.15

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 10:25:03 AM5/3/19
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: Conversion to Integer would give an error when asking for conversion of a decimal string with leading zeros. For example, conversion of "08" with explicit radix 10 would flag this as an error as if the string was supposed to be a valid octal number. This is now fixed so that `Integer("08", 10)` works as expected.
Release Notes: Bug Fix

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 10:26:04 AM5/3/19
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Component/s: Type System
Component/s: Functions

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 10:26:04 AM5/3/19
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Affects Version/s: PUP 5.4.0

Henrik Lindberg (JIRA)

unread,
May 3, 2019, 10:28:03 AM5/3/19
to puppe...@googlegroups.com
 
Re: String to integer conversion fails

I put up a PR with a fix for Puppet 5.5.x branch. Ping Jason Stewart, Nick Walker

Kris Bosland (JIRA)

unread,
May 3, 2019, 2:41:03 PM5/3/19
to puppe...@googlegroups.com
Kris Bosland commented on Bug PUP-9689

Merged to 5.5.x at a187387.

Jarret Lavallee (JIRA)

unread,
May 16, 2019, 6:52:03 PM5/16/19
to puppe...@googlegroups.com
Jarret Lavallee updated an issue
 
Change By: Jarret Lavallee
CS Priority: Needs Priority Reviewed

Oana Tanasoiu (JIRA)

unread,
Jun 10, 2019, 3:24:04 AM6/10/19
to puppe...@googlegroups.com
Oana Tanasoiu commented on Bug PUP-9689
 
Re: String to integer conversion fails

Hi Henrik Lindberg

this was merged into master and will be part of the 6.5.0 release. Can you please let us know if this is resolved by closing the ticket ?

 

Oana Tanasoiu (JIRA)

unread,
Jun 10, 2019, 3:24:04 AM6/10/19
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
 
Change By: Oana Tanasoiu
Fix Version/s: PUP 6.5.0

Heston Hoffman (JIRA)

unread,
Jun 12, 2019, 7:06:03 PM6/12/19
to puppe...@googlegroups.com
Heston Hoffman updated an issue
Change By: Heston Hoffman
Labels: resolved-issue-added

Gheorghe Popescu (JIRA)

unread,
Jul 9, 2019, 7:03:03 AM7/9/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: PUP 6.4.3
Fix Version/s: PUP 6.0.10

Austin Boyd (JIRA)

unread,
Dec 12, 2019, 9:11:07 AM12/12/19
to puppe...@googlegroups.com
Austin Boyd updated an issue
Change By: Austin Boyd
Zendesk Ticket IDs: 34700
Zendesk Ticket Count: 1
Reply all
Reply to author
Forward
0 new messages