Jira (BOLT-1274) Stack trace when inventory config is not a hash or nil

3 views
Skip to first unread message

Cas Donoghue (JIRA)

unread,
Apr 24, 2019, 8:32:03 PM4/24/19
to puppe...@googlegroups.com
Cas Donoghue created an issue
 
Puppet Task Runner / Bug BOLT-1274
Stack trace when inventory config is not a hash or nil
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/04/24 5:31 PM
Priority: Normal Normal
Reporter: Cas Donoghue

Could use better validation to ensure stack trace is not surfaced with malformed config. For example with https://github.com/puppetlabs/bolt/blob/1266668806665d9126397073711efb84dd45b44e/lib/bolt/inventory/group2.rb#L105 we assume target['config'] is either a Hash or nil. I accidentally did config: local and got a stack trace.

NoMethodError: undefined method `keys' for "local":String
  /home/cas/working_dir/bolt/lib/bolt/inventory/group2.rb:106:in `add_target'
  /home/cas/working_dir/bolt/lib/bolt/inventory/group2.rb:59:in `block in initialize'

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Lucy Wyman (JIRA)

unread,
Apr 25, 2019, 1:27:03 PM4/25/19
to puppe...@googlegroups.com
Lucy Wyman updated an issue
Change By: Lucy Wyman
Sprint: Bolt Ready for Grooming Kanban

Cas Donoghue (JIRA)

unread,
May 1, 2019, 6:03:02 PM5/1/19
to puppe...@googlegroups.com

Lucy Wyman (JIRA)

unread,
May 6, 2019, 10:27:03 AM5/6/19
to puppe...@googlegroups.com

Lucy Wyman (JIRA)

unread,
May 6, 2019, 10:27:03 AM5/6/19
to puppe...@googlegroups.com

Melissa Amos (JIRA)

unread,
May 13, 2019, 12:50:04 PM5/13/19
to puppe...@googlegroups.com
Melissa Amos updated an issue
Change By: Melissa Amos
Labels: docs_reviewd docs_reviewed

Melissa Amos (JIRA)

unread,
May 13, 2019, 12:50:04 PM5/13/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages