Jira (PUP-9648) Drop PSON support

[Josh Cooper (JIRA)]

Josh Cooper created an issue

Puppet / PUP-9648 Drop PSON support Issue Type: Improvement Assignee: Unassigned Created: 2019/04/19 9:15 AM Fix Versions: PUP 7.0.0 Priority: Normal Reporter: Josh Cooper Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the file resource's content => binary_file('/path/to/bin'). Now that rich data is supported and enabled by default, we should look into eliminating PSON support. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Team: Coremunity

Add Comment

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-9648

Re: Drop PSON support ping Nick Walker Charlie Sharpsteen is this something that users are relying on? It doesn't look like we have an actual deprecation warning for this yet.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Nick Walker (Jira)]

Nick Walker commented on PUP-9648

Re: Drop PSON support Would this cause older versions of the agent to no longer be able to connect to platform 7 masters?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Epic Link: PUP- 9120 10593

Add Comment

[Rob Braden (Jira)]

Rob Braden updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Rob Braden Labels: platform_7

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Maggie Dreyer Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support. * Where does the fallback code live? Is it centralized or scattered around? * There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer commented on PUP-9648

Re: Drop PSON support I think we might need to make a call on how far back we want to support for agents if we do this. If we are going to say "all of them forever", then this ticket should be closed, because it's not possible to do.

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-9648 Drop PSON support Change By: Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support. * Where does the fallback code live? Is it centralized or scattered around? * There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this.

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-9648 Drop PSON support Change By: Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support. * Where does the fallback code live? Is it centralized or scattered around? * There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this. We think this happened in Puppet 6, which is likely too recent for this to be doable.

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-9648 Drop PSON support Change By: Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support. * Where does the fallback code live? Is it centralized or scattered around? * There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this. We think this happened in [ Puppet 6 |https://tickets.puppetlabs.com/browse/PUP-8587] , which is likely too recent for this to be doable.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Epic Link: PUP-10593

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-9648

Re: Drop PSON support My thinking is we need to support upgrading agents from Puppet 5, but not Puppet 4 (since we're dropping legacy routes support). Rich data was not enabled end to end by default until Puppet 6. We had some rich data support in Puppet 5, but it only really worked on the agent when compiling the catalog, and there were problems with the Puppet 5 loaders. So we probably need to hold off on this change until Puppet 8, when we're sure all agents can upgrade to 8 using rich data.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Fix Version/s: PUP 7.0.0 Fix Version/s: PUP 8.0.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Labels: platform_7

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Epic Link: PA-4664

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Team: Coremunity Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9648 Drop PSON support

Change By: Josh Cooper Sprint: Phoenix 2023-03-29

Add Comment