Jira (BOLT-1222) Support an "apply" step.

Issue Type:	New Feature
Assignee:	Unassigned
Created:	2019/04/01 11:06 AM
Priority:	Normal
Reporter:	Alex Dreyer

We should be able to handle simple apply actions in simple plans.

`apply_prep` should be implicitly called on targets at least once in the plan.
It should support a data format of resource declaration.

Questions:
should we use an array or hash?

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

David Kramer (JIRA)

unread,

May 14, 2019, 12:41:03 PM5/14/19

to puppe...@googlegroups.com

David Kramer updated an issue

Change By:	David Kramer
Sprint:	Bolt Ready for Grooming

Alex Dreyer (JIRA)

unread,

May 15, 2019, 2:04:06 PM5/15/19

to puppe...@googlegroups.com

Alex Dreyer updated an issue

Change By:	Alex Dreyer

We should be able to handle simple apply actions in simple plans.

* `apply_prep` should be implicitly called on targets at least once in the plan.
* It should support a data format of resource declaration.

Questions:
should we use an array or hash?

{noformat}
---
steps:
  # + This allows us to maintain manifest ordering which may be useful
  # - need to come up with safe keyword for resource_type
  - description: "single resource in array"
    resources:
      - _type: class
        title: "foo::bar"
        param1: foo
        noop: true
  - description: "single resource in array"
    resources:
      - type: class
        title: "foo::bar"
        param1: foo
        noop: true
  - resources:
    - package: nginx
    - package: ssh
    - file: /tmp/foo
      parameters:
        content: "hello world"
  - description: "single resource in array"
    resources:
      - type: class
        title: "foo::bar"
        parameters:
          param1: foo
          noop: true
# Using refs may be confusing when people move to puppet code
# Using refs forces users to understand some weird capitalization rules
  - description: "Use ref's as the key"
    Package['nginx']:
    File['/var/...']:
      content: $foo
  - description: "Use ref's as the key"
    - ref: Package['nginx']
    - ref: File['/var/...']
        content: $foo
# No ordering is unacceptable
  - description: "single resource in hash by name"
    resources:
      foo::bar:
        _type: class
        param1: foo
        before: "File['/etc/fop']"
        noop: true
# No ordering is unacceptable
  - description: "single resource in nested hash"
    resources:
      class:
        foo::bar:
          param1: class
          noop: true
{noformat}

Alex Dreyer (JIRA)

unread,

May 15, 2019, 2:07:03 PM5/15/19

to puppe...@googlegroups.com

Alex Dreyer updated an issue

Change By:	Alex Dreyer

We should be able to handle simple apply actions in simple plans.
* `apply_prep` should be implicitly called on targets at least once in the plan.
* It should support a data format of resource declaration.

Questions Observations :
should we use * must be an array or hash? so we can have manifest ordering
* having type and title together on one line is preferable

{noformat}
---
steps:
# + This allows us to maintain manifest ordering which may Can there be useful a parameter called "type" .

# - need to come up with safe keyword for resource_type
-

description: "single resource in array"
resources:
- _type type : class

        title: "foo::bar"
        param1: foo
        noop: true

- description: "single resource in array"

# Allows     resources : to be easily scannable.
      - # Similar to step syntax where the step type : class or resource type is stored by the presence of a key.
        title: # Won't with with " foo::bar parameters " type if one exists.

Lucy Wyman (JIRA)

unread,

Jun 11, 2019, 12:13:05 PM6/11/19

to puppe...@googlegroups.com

Lucy Wyman updated an issue

Change By:	Lucy Wyman
Sprint:	Bolt Ready for Grooming Kanban

Nick Lewis (JIRA)

unread,

Jun 12, 2019, 1:27:05 PM6/12/19

to puppe...@googlegroups.com

Nick Lewis assigned an issue to Nick Lewis

Change By:	Nick Lewis
Assignee:	Nick Lewis

Lucy Wyman (JIRA)

unread,

Jun 13, 2019, 1:08:04 PM6/13/19

to puppe...@googlegroups.com

Lucy Wyman updated an issue

Change By:	Lucy Wyman

We should be able to handle simple apply actions in simple plans.
* `apply_prep` should be implicitly called on targets at least once in the plan.
* It should support a data format of resource declaration.

Observations:
* must be an array so we can have manifest ordering

* having type and title together on one line is preferable

* Test that a type called type works

{noformat}
---
steps:
# Can there be a parameter called "type" .

  - description: "single resource in array"
    resources:
      - type: class
        title: "foo::bar"

param1: foo
noop: true
# Allows resources to be easily scannable.
# Similar to step syntax where the step type or resource type is stored by the presence of a key.
# Won't work with with "parameters" type if one exists.

Lucy Wyman (JIRA)

unread,

Jun 13, 2019, 1:09:03 PM6/13/19

to puppe...@googlegroups.com

Lucy Wyman updated an issue