| Probably some places we should be escaping but we aren't (ie forge) URI.escape is deprecated in Ruby itself. Everyone either needs to use the Puppet URI escape/unescape logic in Puppet::Util, or we need to add something like addressable and using that everywhere. We might not want to expose that as the way to do it, but since this is in Heira, that should be okay. What we should do is use the escape/unescape logic in Puppet::Util everywhere in puppet, and use addressable under the hood there. Then in hiera, we can just straight use addressable because that's in hiera. |
