Jira (FACT-1910) Mountpoint fact only shows tmpfs and physical mounts

24 views
Skip to first unread message

Joseph Voss (JIRA)

unread,
Mar 8, 2019, 3:09:02 PM3/8/19
to puppe...@googlegroups.com
Joseph Voss created an issue
 
Facter / Bug FACT-1910
Mountpoint fact only shows tmpfs and physical mounts
Issue Type: Bug Bug
Affects Versions: FACT 3.10.0
Assignee: Unassigned
Created: 2019/03/08 12:08 PM
Environment:

RedHat

Priority: Normal Normal
Reporter: Joseph Voss

While running puppet inside a container I noticed that the hostname mountpoints are not being picked up by facter. Looking through the code it appears that only physical and tmpfs mounts are currently being loaded into the mountpoint facts (https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82).

 

For me, the expected return for the mountpoint facts are all mount points, not just physical or tmpfs mounts. It appears that others have a similar desire (FACT-1519). Is it possible to remove this check? It was necessary when the partition data was populated within the filesystem_resolver::collect_mountpoint_data function, but it has been since moved to a separate function and is no longer necessary. This was also the original suggestion for FACT-1418.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Joseph Voss (JIRA)

unread,
Mar 8, 2019, 3:45:03 PM3/8/19
to puppe...@googlegroups.com

Joseph Voss (JIRA)

unread,
Mar 14, 2019, 2:27:02 PM3/14/19
to puppe...@googlegroups.com
Joseph Voss updated an issue
 
Change By: Joseph Voss
While running puppet inside a container I noticed that the hostname overlayfs mountpoints are not being picked up by facter. Looking through the code it appears that only physical and tmpfs mounts are currently being loaded into the mountpoint facts ([https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82 |https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82 ]).

 

For me, the expected return for the mountpoint facts are all mount points, not just physical or tmpfs mounts. It appears that others have a similar desire (
[ FACT-1519 |https://tickets.puppetlabs.com/browse/FAC-1519] ). Is it possible to remove this check? It was necessary when the partition data was populated within the filesystem_resolver::collect_mountpoint_data function, but it has been since moved to a separate function and is no longer necessary. This was also the original suggestion for   [ FACT-1418 |https://tickets . puppetlabs.com/browse/FACT-1482?focusedCommentId=333954&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-333954].

Geoff Nichols (JIRA)

unread,
Mar 27, 2019, 1:50:03 AM3/27/19
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Mar 27, 2019, 1:50:05 AM3/27/19
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Mar 29, 2019, 4:19:02 AM3/29/19
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Mar 29, 2019, 4:19:04 AM3/29/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Apr 9, 2019, 11:02:42 AM4/9/19
to puppe...@googlegroups.com

Branan Riley (JIRA)

unread,
Apr 9, 2019, 11:03:25 AM4/9/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
May 29, 2019, 6:13:03 AM5/29/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - Triage 2019-06-12

Mihai Buzgau (JIRA)

unread,
May 29, 2019, 6:13:03 AM5/29/19
to puppe...@googlegroups.com

Oana Tanasoiu (JIRA)

unread,
Jun 11, 2019, 6:19:03 AM6/11/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Jun 12, 2019, 4:21:10 AM6/12/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-06-12 , PR - 2019-06-25

Gheorghe Popescu (JIRA)

unread,
Jul 1, 2019, 3:10:04 AM7/1/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Jul 1, 2019, 3:15:02 AM7/1/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:04:02 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.12.z
Fix Version/s: FACT 3.11.z

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:04:03 AM7/3/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:39:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.13.z
Fix Version/s: FACT 3.12.z
Fix Version/s: FACT 3.11.z
Fix Version/s: FACT 3.13.3
Fix Version/s: FACT 3.12.5
Fix Version/s: FACT 3.11.9

Jean Bond (JIRA)

unread,
Jul 15, 2019, 5:22:03 PM7/15/19
to puppe...@googlegroups.com
Jean Bond updated an issue
Change By: Jean Bond
Labels: resolved-issue-added

Mihai Buzgau (JIRA)

unread,
Jul 18, 2019, 3:46:03 AM7/18/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 3.14.1
Fix Version/s: FACT 3.14.2

Vadym Chepkov (JIRA)

unread,
Jul 22, 2019, 8:41:03 AM7/22/19
to puppe...@googlegroups.com
Vadym Chepkov commented on Bug FACT-1910
 
Re: Mountpoint fact only shows tmpfs and physical mounts

Not sure if it's related, but now facter wrongfully reports type of the root file system as 'rootfs' instead of 'xfs'

Oana Tanasoiu (JIRA)

unread,
Jul 22, 2019, 9:24:03 AM7/22/19
to puppe...@googlegroups.com

Hi Vadym Chepkov,

Could you give us more details about the problem, like the operating system and version you are using. And also the content of /etc/mtab file?

Thank you

Vadym Chepkov (JIRA)

unread,
Jul 22, 2019, 9:28:03 AM7/22/19
to puppe...@googlegroups.com

Sure. Centos7, the latest

# cat /etc/mtab |grep root
rootfs / rootfs rw 0 0
/dev/mapper/vg0-root / xfs rw,relatime,attr2,inode64,noquota 0 0

facter gets confused?

Oana Tanasoiu (JIRA)

unread,
Jul 23, 2019, 10:07:03 AM7/23/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages