Jira (PDB-4285) Review pdb command header value handling and docs

0 views
Skip to first unread message

Rob Browning (JIRA)

unread,
Mar 7, 2019, 2:10:03 PM3/7/19
to puppe...@googlegroups.com
Rob Browning created an issue
 
PuppetDB / Improvement PDB-4285
Review pdb command header value handling and docs
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/03/07 11:09 AM
Priority: Normal Normal
Reporter: Rob Browning

Let's make sure that the payload values for command, version, and certname are always preferred over any header values, and also make sure that the docs make it clear that even when the header values are provided, they need to be duplicated in the payload.

They were only intended as an optimization (to avoid having to parse the command sooner than necessary), and the header values might or might not be preserved intact by the queue (i.e. metadata mangling if/when the certname is too long or has filesystem "forbidden" characters, etc.).

commands.markdown is one place we want to make sure the requirements are clear.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Zachary Kent (Jira)

unread,
Feb 17, 2021, 3:11:04 PM2/17/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Labels: Documentation
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Zachary Kent (Jira)

unread,
Feb 17, 2021, 3:14:03 PM2/17/21
to puppe...@googlegroups.com

Zachary Kent (Jira)

unread,
Feb 17, 2021, 3:14:03 PM2/17/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Epic Link: PDB-4759
Team: PuppetDB HA

David McTavish (Jira)

unread,
Jan 12, 2022, 2:27:02 PM1/12/22
to puppe...@googlegroups.com
David McTavish updated an issue
Change By: David McTavish
Labels: low-hanging-fruit
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo

David McTavish (Jira)

unread,
Jan 12, 2022, 2:27:02 PM1/12/22
to puppe...@googlegroups.com

David McTavish (Jira)

unread,
Jan 12, 2022, 2:27:02 PM1/12/22
to puppe...@googlegroups.com

David McTavish (Jira)

unread,
Jan 12, 2022, 7:20:01 PM1/12/22
to puppe...@googlegroups.com

David McTavish (Jira)

unread,
Jan 26, 2022, 2:48:01 PM1/26/22
to puppe...@googlegroups.com
David McTavish updated an issue
Change By: David McTavish
Sprint: HAHA Froyo - 2 / Grooming 16/2022

David McTavish (Jira)

unread,
Jan 26, 2022, 3:29:02 PM1/26/22
to puppe...@googlegroups.com
David McTavish updated an issue
Change By: David McTavish
Sprint: Froyo HA 2022 - 2/ 02- 16 /2022

David McTavish (Jira)

unread,
Feb 2, 2022, 3:39:02 PM2/2/22
to puppe...@googlegroups.com

Rob Browning (Jira)

unread,
Mar 21, 2022, 5:52:03 PM3/21/22
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 7.10.0
Fix Version/s: PDB 6.20.3
Reply all
Reply to author
Forward
0 new messages