Jira (BOLT-1168) Add catch_errors and better handling to apply_prep

2 views
Skip to first unread message

Chris Barker (JIRA)

unread,
Mar 7, 2019, 1:10:02 PM3/7/19
to puppe...@googlegroups.com
Chris Barker created an issue
 
Puppet Task Runner / Improvement BOLT-1168
Add catch_errors and better handling to apply_prep
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/03/07 10:09 AM
Priority: Normal Normal
Reporter: Chris Barker

Apply_prep and associated tasks can error out if they cannot connect to a host (such as it is no responding over pcp) and it is difficult to troubleshoot since there is no support for catch_errors.

In my run in with this, it was apply_helpers::custom_facts that errored out because a node that was returned from pql was not responding over pcp. The output was 919k of text dumped to the screen (all the facts gathered) and I had to scrape the json to find the one node that had failed - and the error message of "not connected to pcp". This was from a total node count of 12 nodes.

Being able to have apply_prep return the successful nodes (and thus the ones to continue with) would be useful, along with getting the failed nodes to be able to flag as having other issues in the over all plan, would be a big improvement.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Alex Dreyer (JIRA)

unread,
Mar 25, 2019, 11:44:03 AM3/25/19
to puppe...@googlegroups.com
Alex Dreyer commented on Improvement BOLT-1168
 
Re: Add catch_errors and better handling to apply_prep

The workaround for catch_errors is to create a plan that only runs an apply_prep and call that plan with _catch_errors

Chris Barker (JIRA)

unread,
Mar 25, 2019, 12:09:04 PM3/25/19
to puppe...@googlegroups.com
Chris Barker commented on Improvement BOLT-1168

That is asking a lot of a novice new to the platform writing their first plan with a bolt apply to first write a new plan with catch_errors in that, then do bolt apply in the original plan.

Lucy Wyman (JIRA)

unread,
Jun 27, 2019, 3:47:03 PM6/27/19
to puppe...@googlegroups.com
Lucy Wyman commented on Improvement BOLT-1168

Does the catch_errors() function work for this?

Alex Dreyer (JIRA)

unread,
Jun 27, 2019, 3:54:03 PM6/27/19
to puppe...@googlegroups.com
Alex Dreyer commented on Improvement BOLT-1168

I think so. We should verify and perhaps mention that in the apply_prep docs.

Reply all
Reply to author
Forward
0 new messages