Jira (BOLT-1154) Evaluate guard conditions in bolt plan functions

Cas Donoghue (JIRA)

unread,

Feb 27, 2019, 4:21:03 PM2/27/19

to puppe...@googlegroups.com

Cas Donoghue created an issue

Puppet Task Runner /

BOLT-1154

Evaluate guard conditions in bolt plan functions

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2019/02/27 1:20 PM
Priority:	Normal
Reporter:	Cas Donoghue

BOLT-1131 involved defining explicitly which plan functions are available in apply blocks. The TASK_OPERATION_NOT_SUPPORTED_WHEN_COMPILING issue from the Puppet::Pops::Issues module (https://github.com/puppetlabs/puppet/blob/aaebc6cd3769c937f7da59320daadfa68ca8da23/lib/puppet/pops/issues.rb#L904-L914) had been raised when guarding incompatible plan functions in apply blocks. The work in https://github.com/puppetlabs/bolt/pull/876 introduced a pattern for defining puppet issues in bolt and replaced the TASK_OPERATION_NOT_SUPPORTED_WHEN_COMPILING.

There is another guard for plan functions that will raise a similar issue: TASK_MISSING_BOLT. It seems like there are places where the guard logic is unnecessary. We should evaluate each plan function that can raise TASK_MISSING_BOLT and determine if it is necessary and whether to replace it with an issue defined in bolt. We should also evaluate removing the issues from puppet that have been replaced in bolt.