Jira (PUP-9510) Reduce feature-related debug messages from puppettypes to once per provider

Charlie Sharpsteen (JIRA)

unread,

Feb 22, 2019, 7:11:08 PM2/22/19

to puppe...@googlegroups.com

Charlie Sharpsteen created an issue

Puppet /

PUP-9510

Reduce feature-related debug messages from puppet types to once per provider

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2019/02/22 4:10 PM
Priority:	Normal
Reporter:	Charlie Sharpsteen

From PUP-8586:

If a type's property/parameter depends on a provider feature, and that provider feature isn't available, we repeat the same set of messages for every instance of that resource type. I think we should only emit the message once per resource type (and possibly once if the feature becomes true later in the run if the command, feature, etc becomes available):

Debug: /Firewall[a]: Provider iptables does not support features hop_limiting; not managing attribute hop_limit

Debug: /Firewall[a]: Provider iptables does not support features ishasmorefrags; not managing attribute ishasmorefrags

Debug: /Firewall[a]: Provider iptables does not support features islastfrag; not managing attribute islastfrag

Debug: /Firewall[a]: Provider iptables does not support features isfirstfrag; not managing attribute isfirstfrag

...

Debug: /Firewall[b]: Provider iptables does not support features hop_limiting; not managing attribute hop_limit

Debug: /Firewall[b]: Provider iptables does not support features ishasmorefrags; not managing attribute ishasmorefrags

Debug: /Firewall[b]: Provider iptables does not support features islastfrag; not managing attribute islastfrag

Debug: /Firewall[b]: Provider iptables does not support features isfirstfrag; not managing attribute isfirstfrag

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Charlie Sharpsteen (JIRA)

unread,

Feb 22, 2019, 7:16:02 PM2/22/19

to puppe...@googlegroups.com

Charlie Sharpsteen commented on

PUP-9510

Re: Reduce feature-related debug messages from puppet types to once per provider

The problem with just adding the Puppet::Util::Warnings warnings module and using debug_once is that all of the debug messages are then routed via the top-level Puppet.debug method instead of using the local debug method that the Puppet::Type instance has. This means that we loose the additional information that Puppet::Util::Logging provides when it's methods are called from a Type instance.

I think this can be accommodated by the logging methods in {Puppet::Util::Warnings to take a second argument indicating which object should receive the notice, debug, and warn method calls and have that parameter default to the top-level Puppet module.