Jira (PUP-9508) Puppet::Util::Warnings#maybe

Jacob Helwig (JIRA)

unread,

Feb 21, 2019, 5:20:03 PM2/21/19

to puppe...@googlegroups.com

Jacob Helwig created an issue

Puppet /

PUP-9508

Puppet::Util::Warnings#maybe_log potentially very slow

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2019/02/21 2:19 PM
Priority:	Normal
Reporter:	Jacob Helwig

https://github.com/puppetlabs/puppet/blob/293b87447ff955bb4c866b5b0eda3a23e5901ff2/lib/puppet/util/warnings.rb#L23-L30

Puppet::Util::Warnings#maybe_log stores the list of messages that it has logged from each class in an array, and uses Array#include? to see whether the message has already been seen. This has the potential to slow down significantly as the number of messages logged from a specific class increases.

We should probably look into storing the set of previously seen messages in something with a lookup time closer to O(1) than the current O(N) scan through the array.

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Henrik Lindberg (JIRA)

unread,

Feb 22, 2019, 6:26:03 AM2/22/19

to puppe...@googlegroups.com

Henrik Lindberg commented on

PUP-9508

Re: Puppet::Util::Warnings#maybe_log potentially very slow

How about just replacing the Array of messages with an instance of Set?

Add Comment

Jacob Helwig (JIRA)

unread,

Feb 22, 2019, 12:20:03 PM2/22/19

to puppe...@googlegroups.com

Jacob Helwig commented on

PUP-9508

Re: Puppet::Util::Warnings#maybe_log potentially very slow

If checking whether something is already a member of a Set in Ruby is closer to O(1) than the O(N) that we have now, that certainly meets the criteria. I haven't dug into the implementation of Set in Ruby yet to see. This is mostly something the Coremunity team noticed while reviewing nearby code, and we opened the ticket to make sure that there was a reminder that there was something to follow up on. There wasn't a specific implementation in mind other than "not the one we're using now" when opening this ticket.