Jira (PUP-9469) Remove the setting to turn off func 3x API validation

20 views
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
Jan 31, 2019, 7:52:03 AM1/31/19
to puppe...@googlegroups.com
Henrik Lindberg created an issue
 
Puppet / Improvement PUP-9469
Remove the setting to turn off func 3x API validation
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/01/31 4:51 AM
Fix Versions: PUP 7.0.0
Priority: Normal Normal
Reporter: Henrik Lindberg

In PUP-9294 we introduced a setting to turn off validation of 3.x functions - this in case the validation logic itself would cause problems. Since it is on by default, by now (for Puppet 7) we would have experienced if it caused problems in real world use. Since it probably did not cause problems, we should now remove this setting.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Rob Braden (JIRA)

unread,
Feb 4, 2019, 5:05:03 PM2/4/19
to puppe...@googlegroups.com

Melissa Stone (Jira)

unread,
Apr 29, 2020, 5:18:05 PM4/29/20
to puppe...@googlegroups.com
Melissa Stone commented on Improvement PUP-9469
 
Re: Remove the setting to turn off func 3x API validation

Justin Stoller Maggie Dreyer could you scope this removal? Are there any deprecations that need to be added to Puppet 6.16 before the setting is removed?

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Justin Stoller (Jira)

unread,
Apr 29, 2020, 5:46:03 PM4/29/20
to puppe...@googlegroups.com

Yes, we should add a deprecation notice for users who set the func3x_check setting to false. It currently defaults to true. There is one conditional in code that honors this setting it should be trivial to remove.

Josh Cooper (Jira)

unread,
Jul 21, 2020, 12:51:03 PM7/21/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Epic Link: PUP- 9120 10591

Josh Cooper (Jira)

unread,
Oct 19, 2020, 2:52:03 PM10/19/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Froyo Coremunity

Josh Cooper (Jira)

unread,
Oct 20, 2020, 8:10:03 PM10/20/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (Jira)

unread,
Oct 20, 2020, 8:10:03 PM10/20/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 21, 2020, 7:32:04 PM10/21/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Bug Fix
Release Notes Summary: Removes the `func3x_check` setting, as a result all 3x functions are validated.

Josh Cooper (Jira)

unread,
Oct 23, 2020, 2:43:04 PM10/23/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Nov 10, 2020, 5:02:02 AM11/10/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
 
Change By: Claire Cadman
Labels: doc_reviewed platform_7
Reply all
Reply to author
Forward
0 new messages