Jira (PUP-9407) Don't backup to the local filebucket by default

Josh Cooper (JIRA)

unread,

Jan 9, 2019, 6:04:03 PM1/9/19

to puppe...@googlegroups.com

Josh Cooper created an issue

Puppet /

PUP-9407

Don't backup to the local filebucket by default

Issue Type:	Bug
Assignee:	Unassigned
Created:	2019/01/09 3:03 PM
Fix Versions:	PUP 7.0.0
Priority:	Normal
Reporter:	Josh Cooper

Puppet agent's will backup any overwritten or deleted file to its local filebucket via the default backup parameter for the file type. It defaults to puppet which means to use the filebucket named puppet which is automatically created.

Many users run into trouble because the filebucket will grow unbounded, such as ~~PUP-1137~~. It has been proposed to use the tidy resource to clean up stale files, but can lead to memory issues with large numbers of file resources being created. See https://github.com/npwalker/pe_metric_curl_cron_jobs/issues/3

For this ticket we should change the default value of the bucket parameter from puppet to false, see https://github.com/puppetlabs/puppet/blob/6.1.0/lib/puppet/type/file.rb#L110, and update the file reference documentation to reflect the new behavior.

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Chris Denneen (JIRA)

unread,

Nov 7, 2019, 1:32:03 PM11/7/19

to puppe...@googlegroups.com

Chris Denneen commented on

PUP-9407

Re: Don't backup to the local filebucket by default

I think the filebucket as it's been implemented it might be okay to remove since honestly I don't think anyone actually uses it.

The issue there is I don't think they use it because it isn't a useful feature, sadly I think they don't use it because it's not a very clear feature to use. (or simple with needing to use checksums)

If this becomes a clearer/easier feature then I think it actually could be very useful for people.

Add Comment

Sean Millichamp (JIRA)

unread,

Nov 8, 2019, 7:57:02 AM11/8/19

to puppe...@googlegroups.com

Sean Millichamp commented on

PUP-9407

Re: Don't backup to the local filebucket by default

Chris Denneen I would say it is most definitely not okay to remove until/unless there is a suitable replacement. I'm fine having it disabled by default, but our ops folks depend on being able to quickly see/recover files overwritten by Puppet. I'll grant it isn't super easy to use (with the checksums, etc.) but in this case something is better than nothing.

Add Comment

Melissa Stone (Jira)

unread,

Apr 29, 2020, 5:10:03 PM4/29/20

to puppe...@googlegroups.com

Melissa Stone commented on

PUP-9407

Re: Don't backup to the local filebucket by default

This is a good thing to pull into Puppet 7. In addition to changing the default value, we should add a comment stating that it's the users responsibility to ensure the backup does not grow out of hand.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Josh Cooper (Jira)

unread,

Aug 7, 2020, 8:43:03 PM8/7/20

to puppe...@googlegroups.com

Josh Cooper assigned an issue to Josh Cooper

Puppet /

PUP-9407

Don't backup to the local filebucket by default

Change By:	Josh Cooper
Assignee:	Josh Cooper

Add Comment

Josh Cooper (Jira)

unread,

Aug 7, 2020, 8:53:02 PM8/7/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-9407

Don't backup to the local filebucket by default

Change By:	Josh Cooper
Release Notes:	Bug Fix
Release Notes Summary:	Puppet will no longer backup files it overwrites or deletes by default to the local filebucket, since it will grow unbounded over time. The local filebucket can be re-enabled by setting `File { backup => 'puppet' }` as a resource default.