Jira (FACT-1903) facter doesn't recognize EC2 i3.metal instances

15 views
Skip to first unread message

Ryan McKern (JIRA)

unread,
Jan 9, 2019, 11:46:03 AM1/9/19
to puppe...@googlegroups.com
Ryan McKern created an issue
 
Facter / Bug FACT-1903
facter doesn't recognize EC2 i3.metal instances
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/01/09 8:45 AM
Environment:

AWS EC2, i3.metal instance

Debian Jessie or Stretch

Labels: aws ec2
Priority: Normal Normal
Reporter: Ryan McKern

i3.metal instances aren’t $virtual as far as puppet is concerned, so there is a problem where facter doesn’t populate ec2_metadata on i3.metal instances as a result. If we force the facter virtual fact to be kvm, then puppet can run just fine on that instance type.

An example of the logic involved in determining if an instance is on EC2 is here:
https://github.com/puppetlabs/facter/blob/master/lib/src/facts/resolvers/ec2_resolver.cc#L117

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Ryan McKern (JIRA)

unread,
Jan 9, 2019, 12:06:03 PM1/9/19
to puppe...@googlegroups.com
Ryan McKern updated an issue
Change By: Ryan McKern
i3.metal instances aren’t {{$virtual}} as far as puppet is concerned, so there is a problem where facter doesn’t populate {{ec2_metadata}} on i3.metal instances as a result. If we force the facter {{virtual}} fact to be kvm, then puppet can run just fine on that instance type.

An example of the logic involved in determining if an instance is on EC2 is here:
https://github.com/puppetlabs/facter/blob/master/lib/src/facts/resolvers/ec2_resolver.cc#L117


(Credit to [~coneill] for finding this -- I'm just the messenger.)

Branan Riley (JIRA)

unread,
Jan 11, 2019, 4:39:03 PM1/11/19
to puppe...@googlegroups.com
Branan Riley updated an issue
Change By: Branan Riley
Labels: aws ec2 sadness

Geoff Nichols (JIRA)

unread,
Jan 22, 2019, 2:12:03 PM1/22/19
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Jan 22, 2019, 2:12:04 PM1/22/19
to puppe...@googlegroups.com
Geoff Nichols updated an issue
Change By: Geoff Nichols
Labels: aws cloud ec2 sadness

Mihai Buzgau (JIRA)

unread,
Jan 7, 2020, 2:56:03 AM1/7/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Team: Platform OS Night's Watch

Mihai Buzgau (JIRA)

unread,
Jan 7, 2020, 2:56:03 AM1/7/20
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Jan 7, 2020, 5:53:03 AM1/7/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR NW - Triage 2020-01-22

Mihai Buzgau (JIRA)

unread,
Jan 7, 2020, 5:53:03 AM1/7/20
to puppe...@googlegroups.com

Gabriel Nagy (JIRA)

unread,
Jan 9, 2020, 4:06:03 AM1/9/20
to puppe...@googlegroups.com

Gabriel Nagy (JIRA)

unread,
Jan 9, 2020, 4:36:04 AM1/9/20
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Attachment: facter.txt

Gabriel Nagy (JIRA)

unread,
Jan 9, 2020, 4:36:04 AM1/9/20
to puppe...@googlegroups.com
Gabriel Nagy commented on Bug FACT-1903
 
Re: facter doesn't recognize EC2 i3.metal instances

Tested this on a i3.metal instance with Debian Stretch with puppet-agent 6.11.1 and it works fine for me, see facter output:

facter.txt

# facter --version
3.14.6 (commit 47c91659d7220d0b5c536f7e5fb1a541c1f0d36c)

 

Ryan McKern (JIRA)

unread,
Jan 9, 2020, 6:00:04 PM1/9/20
to puppe...@googlegroups.com
Ryan McKern commented on Bug FACT-1903

Looks like the fix for us would be to roll forward then:

mckern ~ $ dpkg -l | grep puppet
ii  puppet-agent                        1.8.3-1jessie                        amd64        The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, hiera and mcollective.
mckern ~ $ facter -v
3.5.1 (commit 4dd3423921c3e46906942fa76bebff7afbc1c0e7)

Ryan McKern (JIRA)

unread,
Jan 9, 2020, 6:02:04 PM1/9/20
to puppe...@googlegroups.com
Ryan McKern commented on Bug FACT-1903

Also, y'all saw that this sat opened and unacknowledged for almost a year, right?

Gabriel Nagy (JIRA)

unread,
Jan 10, 2020, 9:34:04 AM1/10/20
to puppe...@googlegroups.com
Gabriel Nagy commented on Bug FACT-1903

Sorry about that Ryan McKern. Facter (& co) ownership was transferred to our team sometime last year, and this ticket seems to have slipped through the cracks of JIRA.

Reply all
Reply to author
Forward
0 new messages