Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

[Mihkel Ader (JIRA)]

Mihkel Ader created an issue

Puppet / PUP-9365 Newlines in resource titles result in invalid .dot files Issue Type: Bug Assignee: Unassigned Created: 2018/12/17 4:49 AM Priority: Trivial Reporter: Mihkel Ader Puppet Version: 6.0.4 Puppet Server Version: OS Name/Version: Linux Puppet does not escape newlines in resource titles when generating graph files:   # puppet apply --graph -e 'notify {"line1\nline2":}' ... # dotty .puppetlabs/opt/puppet/cache/state/graphs/resources.dot graph parser: string ran past end of line near line 18 context: >>> Notif <<< y[line1 line1 dotty.lefty: cannot load graph Desired Behavior: Newlines in generated node IDs and labels should be escaped with \ Actual Behavior: Newlines are not escaped, .dot files have syntax errors   Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Eric Sorenson (JIRA)]

Eric Sorenson commented on PUP-9365

Re: Newlines in resource titles result in invalid .dot files Titles with newlines are kind of unspecified behaviour - what is the problem you are trying to solve here? cc Henrik Lindberg - not sure if a title with embedded newline is even an acceptable syntax

Add Comment

[Eric Sorenson (JIRA)]

Eric Sorenson assigned an issue to Mihkel Ader

Puppet / PUP-9365

Newlines in resource titles result in invalid .dot files

Change By: Eric Sorenson Assignee: Mihkel Ader

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-9365

Re: Newlines in resource titles result in invalid .dot files The only real constraint is that a title must be unique for all instances of the resource type and that it should not contain square brackets - what happens if there is a newline in that string is indeed unspecified and I suspect that there are quite a few use cases where that could lead to surprising results.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-9365

Re: Newlines in resource titles result in invalid .dot files

For anyone that want to work on this - I think the logic is here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/graph/simple_graph.rb#L439 For some values it calls a stringify method, and it only deals with embedded double quotes. Not certain if something similar is needed for values that are used in DOT output without stringifying them.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9365

Newlines in resource titles result in invalid .dot files

Change By: Josh Cooper Labels: help_wanted

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9365 Newlines in resource titles result in invalid .dot files

Change By: Josh Cooper Labels: beginner help_wanted

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9365 Newlines in resource titles result in invalid .dot files

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-9365

Re: Newlines in resource titles result in invalid .dot files This hasn't been updated in a few years and we don't have plans on fixing this anytime soon. If anyone wants to work on this, please reopen and ping us in slack if you have questions.

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)