Jira (PUP-9309) Remove unused AST class SublocatedExpression

[Henrik Lindberg (JIRA)]

Henrik Lindberg created an issue

Puppet / PUP-9309 Remove unused AST class SublocatedExpression Issue Type: Improvement Assignee: Unassigned Created: 2018/11/12 2:21 AM Fix Versions: PUP 7.0.0 Priority: Normal Reporter: Henrik Lindberg In PUP-9303, the handling of sublocated expressions was refactored and the SublocatedExpression class is no longer needed. It had to remain in Puppet 5.x and 6.x because logic that processes AST may have references to this class even if the parser (after PUP-9303) does not generate this expression. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-9309

Re: Remove unused AST class SublocatedExpression Maggie Dreyer does a deprecation warning need to be filed before this class is removed?

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Maggie Dreyer (Jira)]

Maggie Dreyer commented on PUP-9309

Re: Remove unused AST class SublocatedExpression

Honestly not sure... Inclined to say no, though. I don't fully understand the statement about why it couldn't be removed previously though, so we should make sure we have a grasp on that before answering that.

Add Comment

[Henrik Lindberg (Jira)]

Henrik Lindberg commented on PUP-9309

Re: Remove unused AST class SublocatedExpression

No need to deprecate other than in release notes IMO - only highly specialized logic that deals with parsing would be affected. For example nwops debugger, maybe puppet strings.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-9309

Remove unused AST class SublocatedExpression

Change By: Josh Cooper Epic Link: PUP- 9120 10591

Add Comment