Jira (PUP-9252) injection of PAL compiler in 4.x function does not work when not invoked by PAL

1 view
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
Oct 19, 2018, 6:28:03 AM10/19/18
to puppe...@googlegroups.com
Henrik Lindberg created an issue
 
Puppet / Bug PUP-9252
injection of PAL compiler in 4.x function does not work when not invoked by PAL
Issue Type: Bug Bug
Assignee: Henrik Lindberg
Created: 2018/10/19 3:27 AM
Priority: Normal Normal
Reporter: Henrik Lindberg

When writing an "internal" function - it is possible to inject a catalog compiler or a script compiler such that it is given to the method called by a dispatcher. This does however only work when a function is called for a compilation that was initiated using PAL.

That is bad because it is very useful to be able to get the current compiler. While it is available, the way in it is obtained, as well as the exposure to implementation details is not great. In contrast the interfaces that are returned as a CatalogCompiler and a ScriptCompiler using the PAL APIs are designed to have only API methods.

It should be a simple fix to make sure that a Catalog/Script compiler is obtained also when compilation is initiated through other means than PAL.

Se also PUP-8594 regarding specification needed for the 4.x API.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Dec 6, 2018, 3:43:03 AM12/6/18
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-9252
 
Re: injection of PAL compiler in 4.x function does not work when not invoked by PAL

PUP-9254 contains a fix for this - there is a PR ready to be merged.

Henrik Lindberg (JIRA)

unread,
Dec 6, 2018, 3:43:03 AM12/6/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Dec 7, 2018, 4:53:03 AM12/7/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Dec 10, 2018, 10:26:04 AM12/10/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Dec 12, 2018, 2:18:04 PM12/12/18
to puppe...@googlegroups.com
Kenn Hussey updated an issue
Change By: Kenn Hussey
Fix Version/s: PUP 6.1.0
Fix Version/s: PUP 6.y

Kenn Hussey (JIRA)

unread,
Dec 12, 2018, 4:06:03 PM12/12/18
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 12, 2020, 4:50:03 PM6/12/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-9252
 
Re: injection of PAL compiler in 4.x function does not work when not invoked by PAL

The eval PR was declined, resetting this ticket status.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2021, 8:22:01 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-9252

We don't have plans on implementing this anytime soon, so I'm going to close. Please reopen if this is needed.

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2021, 8:22:02 PM6/11/21
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages