Jira (FACT-1887) Facter takes very long to run on systems with huge amounts of ZFS filesystems

[Peter Eriksson (JIRA)]

Peter Eriksson created an issue

Facter / FACT-1887 Facter takes very long to run on systems with huge amounts of ZFS filesystems Issue Type: Improvement Affects Versions: FACT 3.11.1 Assignee: Unassigned Created: 2018/10/02 7:36 AM Environment: FreeBSD 11.2 Priority: Normal Reporter: Peter Eriksson The code in Facter that retrieves the ZFS filesystem version is using the command "zfs upgrade" which prints the (hardcoded into the "zfs" binary) version number - and then checks all the filesystems in the computer. Something that sometimes takes a loooooooong time on big servers with a lot of filesystems (hours on one with >88000 ZFS filesystems...) On FreeBSD a much better way to get the ZFS version is using the "sysctl" command:   sysctl vs.zfs.version.zpl (Which also returns the ZFS version in use in the kernel and nu just the precompiled version number in the zfs binary) It would be nice if there was some way to disable the Facter code that tries to list all the filesystems on these machines (we binary-patched away the "/sbin/zfs list" call (since that many filesystems broke the PuppetDB - the facts got too big) in the Facter binary, but the ZFS version check seems to be somewhere else...   Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Scott McClellan (JIRA)]

Scott McClellan assigned an issue to Branan Riley

Facter / FACT-1887 Facter takes very long to run on systems with huge amounts of ZFS filesystems

Change By: Scott McClellan Assignee: Branan Riley

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1887 Facter takes very long to run on systems with huge amounts of ZFS filesystems

Change By: Scott McClellan Team: Platform OS

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1887 Facter takes very long to run on systems with huge amounts of ZFS filesystems

Change By: Scott McClellan Labels: bsd performance solaris zfs

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1887

Re: Facter takes very long to run on systems with huge amounts of ZFS filesystems Hi, It sounds like we may just need to add ZFS to the list of blockable resolvers in facter.conf (https://puppet.com/docs/facter/3.9/configuring_facter.html) - does that sound like it would solve your problem?

Add Comment

[Peter Eriksson (JIRA)]

Peter Eriksson commented on FACT-1887

Re: Facter takes very long to run on systems with huge amounts of ZFS filesystems

Yes, that would probably be a good solution for us.   But please note that there are two different code paths in Facter that calls code that would trigger a slow walk thru of all the ZFS filesystems - "/sbin/zfs list" (compiled into the "Facter" binary) and "zfs upgrade" (in some Ruby code).

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-1887

Facter takes very long to run on systems with huge amounts of ZFS filesystems

Change By: Josh Cooper Team: Platform OS Phoenix

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-1887

Re: Facter takes very long to run on systems with huge amounts of ZFS filesystems Facter 3 is EOL, but Facter 4 calls zfs upgrade -v so would be subject to the same problem. Since it's possible to block zfs related facts, I'm going to close this. But if you'd like to contribute a pull request, then please do and reopen this ticket.

Add Comment