Jira (FACT-1883) facter 3.11.4 build broken on OpenBSD utmpx is not available

[Sebastian Reitenbach (JIRA)]

Sebastian Reitenbach created an issue

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available Issue Type: Bug Affects Versions: FACT 3.11.4 Assignee: Unassigned Created: 2018/09/17 6:29 AM Environment: OpenBSD 6.3 amd64 Priority: Normal Reporter: Sebastian Reitenbach in the uptime resolver, facter 3.11.3 was just calling out to the "uptime" binary, in 3.11.4, that change to get the uptime via the utmpx interface, which apparently is not available on OpenBSD, and therefore breaks building. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Scott McClellan Team: Platform OS

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan assigned an issue to Branan Riley

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Scott McClellan Assignee: Branan Riley

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Branan Riley Labels: bsd help_wanted

Add Comment

[Branan Riley (JIRA)]

Branan Riley assigned an issue to Unassigned

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Branan Riley Assignee: Branan Riley

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1883

Re: facter 3.11.4 build broken on OpenBSD utmpx is not available Hi Sebastian, OpenBSD support in Facter is community-supported (and as you can tell by us breaking it, we don't have test infrastructure for it here at Puppet). We'll happily take a pull request to fix this, but aren't likely to get around to it ourselves any time soon.

Add Comment

[Sebastian Reitenbach (JIRA)]

Sebastian Reitenbach commented on FACT-1883

Re: facter 3.11.4 build broken on OpenBSD utmpx is not available

Hi Brannan,   I guess adding a configure script, checking for availability of utmpx.h would be the most clean thing to do, however, I'm not overly intimate with cmake, as well as c++ is not my most favourite language. So, if the only thing I can come up with, would be a simple: #ifdef _OpenBSD_ #else ...   also OK?

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1883

Re: facter 3.11.4 build broken on OpenBSD utmpx is not available

Yeah, I think that would be fine. It looks like OpenBSD is likely to be the only platform without utmpx that we'd want to try to support.

Add Comment

[Sebastian Reitenbach (JIRA)]

Sebastian Reitenbach commented on FACT-1883

Re: facter 3.11.4 build broken on OpenBSD utmpx is not available

took me a while to get to it, but see: https://github.com/puppetlabs/facter/pull/1750 I went the I think more elegant route, adding a configure check, and defining HAVE_UTMPX_H in case the header file is found. Based on that define, I compile the utmpx_file.cc and made some changes to the uptime_resolver.c, to only use the fallback of calling the uptime binary when it's not available.   does that look good?

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1883

facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Branan Riley Sprint: Platform OS Kanban

Add Comment

[Gabriel Nagy (JIRA)]

Gabriel Nagy assigned an issue to Gabriel Nagy

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Gabriel Nagy Assignee: Gabriel Nagy Team: Platform OS Puppet Romania Sprint: PR - 2019-06-25

Add Comment

[Gheorghe Popescu (JIRA)]

Gheorghe Popescu updated an issue

Facter / FACT-1883 facter 3.11.4 build broken on OpenBSD utmpx is not available

Change By: Gheorghe Popescu Fix Version/s: FACT 3.14.1

Add Comment