Jira (PUP-9109) File: source attribute broken for HTTP(s) URI's containing query parameters

[Matthias Baur (JIRA)]

Matthias Baur created an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters Issue Type: Bug Affects Versions: PUP 5.5.6, PUP 4.10.0 Assignee: Matthias Baur Created: 2018/09/06 4:02 AM Priority: Normal Reporter: Matthias Baur Puppet Version: 4.4.0 - 5.5.6 Puppet Server Version: All OS Name/Version: All We want to use the `source` attribute of the file type to get host specific stuff from a web service. For this we're using the following code: file { '/etc/path/to/file': ensure => file, source => 'https://fancywebservice.example.org/get_host_specific_config.py?host=foobar' } The important part here is the `host=foobar` parameter. If it's not added, the web service will return a 404. Desired Behavior: The file type should be able to retrieve a file from a http(s) URL which contains query parameters Actual Behavior: Error: /Stage[main]/Main/File[/etc/path/to/file]: Could not evaluate: Could not retrieve information from environment production source(s) https://fancywebservice.example.org/get_host_specific_config.py?host=foobar This happens, because Puppet, for reason unknown to me, requests only the `path` element of the uri and skips on the query parameters: https://github.com/puppetlabs/puppet/blob/7ec328f0832492353cad5b2b3ae6e90449fa105f/lib/puppet/util/http_proxy.rb#L184   I will submit a PR to fix this. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Matthias Baur (JIRA)]

Matthias Baur commented on PUP-9109

Re: File: source attribute broken for HTTP(s) URI's containing query parameters PR: https://github.com/puppetlabs/puppet/pull/7051

Add Comment

[Matthias Baur (JIRA)]

Matthias Baur assigned an issue to Unassigned

Puppet / PUP-9109

File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Matthias Baur Assignee: Matthias Baur

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Josh Cooper Fix Version/s: PUP 6.4.4

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Kris Bosland (JIRA)]

Kris Bosland commented on PUP-9109

Re: File: source attribute broken for HTTP(s) URI's containing query parameters Merged into 6.4.x at deaee8b.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9109

File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Josh Cooper Release Notes Summary: Puppet now preserves query parameters when retrieving file metadata and content for http/https file resources. Release Notes: Bug Fix

Add Comment

[Mihai Buzgau (JIRA)]

Mihai Buzgau updated an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Mihai Buzgau Fix Version/s: PUP 6.10.0

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9109 File: source attribute broken for HTTP(s) URI's containing query parameters

Change By: Jean Bond Labels: resolved-issue-added

Add Comment