Jira (PUP-8986) Puppet agent crashes because of bug in pip provider

[Felix Sperling (JIRA)]

Felix Sperling created an issue

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider Issue Type: Bug Assignee: Unassigned Components: Types and Providers Created: 2018/07/06 5:14 AM Priority: Normal Reporter: Felix Sperling Puppet Version: 4.8.2 OS Name/Version: Debian 8.10   When trying to install a package with the pip provider puppet agent -t fails with Info: Using configured environment 'xxx' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for myhost.com Info: Applying configuration version '123213' Error: Failed to apply catalog: undefined method `[]' for nil:NilClass   with --trace it points to:   Error: Failed to apply catalog: undefined method `[]' for nil:NilClass /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:64:in `block (2 levels) in pip_version' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:63:in `each' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:63:in `collect' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:63:in `block in pip_version' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/execution.rb:81:in `block (2 levels) in execpipe' /opt/puppetlabs/puppet/lib/ruby/2.1.0/open-uri.rb:36:in `open' /opt/puppetlabs/puppet/lib/ruby/2.1.0/open-uri.rb:36:in `open' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/execution.rb:80:in `block in execpipe' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:128:in `withenv' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/execution.rb:79:in `execpipe' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider.rb:117:in `execpipe' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:62:in `pip_version' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package/pip.rb:43:in `instances' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/package.rb:4:in `prefetch' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:323:in `prefetch' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:223:in `prefetch_if_necessary' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:107:in `block in evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:116:in `call' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:116:in `traverse' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:154:in `evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:222:in `block in apply' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/log.rb:155:in `with_destination' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/report.rb:142:in `as_logging_destination' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:221:in `apply' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:171:in `block in apply_catalog' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:223:in `block in benchmark'   The code is: 1 def self.pip_version 2 pip_cmd = self.pip_cmd 3 return nil unless pip_cmd execpipe [pip_cmd, '--version'] do |process| 5 process.collect do |line| 6 return line.strip.match(/^pip (\d+\.\d+\.?\d*).*$/)[1] 7 end 8 end 9 end Line 6 fails when "pip --version" returns other information: # pip --version /usr/local/lib/python2.7/dist-packages/urllib3/contrib/socks.py:37: DependencyWarning: SOCKS support in urllib3 requires the installation of optional dependencies: specifically, PySocks. For more information, see https://urllib3.readthedocs.io/en/latest/contrib.html#socks-proxies DependencyWarning pip 1.5.6 from /usr/lib/python2.7/dist-packages (python 2.7) Because then there is no match, it returns null and using [1] on null obviously fails. Installing python-pysocks removes the warning and fixes the puppet run. Desired Behavior: The pip_version function should be able to handle additional output. Either by checking if there is a match or by filtering out stderr.   Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper Team: Platform OS

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8986

Re: Puppet agent crashes because of bug in pip provider Is the DependencyWarning emitted on stderr? Or is it interleaved with the expected pip 1.5.6 ... on stdout?

Add Comment

[Felix Sperling (JIRA)]

Felix Sperling commented on PUP-8986

Re: Puppet agent crashes because of bug in pip provider

Yes, the warning is on stderr.   $ pip --version

/usr/local/lib/python2.7/dist-packages/urllib3/contrib/socks.py:37: DependencyWarning: SOCKS support in urllib3 requires the installation of optional dependencies: specifically, PySocks. For more information, see https://urllib3.readthedocs.io/en/latest/contrib.html#socks-proxies DependencyWarning pip 1.5.6 from /usr/lib/python2.7/dist-packages (python 2.7)

$ pip --version 2> /dev/null

pip 1.5.6 from /usr/lib/python2.7/dist-packages (python 2.7)

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-8986

Puppet agent crashes because of bug in pip provider

Change By: Branan Riley Labels: Easy linux package pip type_and_provider

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper Team: Platform OS Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8986

Re: Puppet agent crashes because of bug in pip provider I ran into this when debugging PUP-9647.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8986

Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper *Puppet Version: 4.8.2* *OS Name/Version: Debian 8.10*

When trying to install a package with the pip provider puppet agent -t fails with

{code:java}

Info: Using configured environment 'xxx' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for myhost.com Info: Applying configuration version '123213' Error: Failed to apply catalog: undefined method `[]' for nil:NilClass

{code}

with --trace it points to:

{code:java}

{code} The code is: {code:java}

1  def self.pip_version 2    pip_cmd = self.pip_cmd 3    return nil unless pip_cmd

4     execpipe [pip_cmd, '--version'] do |process|

5      process.collect do |line| 6        return line.strip.match(/^pip (\d+\.\d+\.?\d*).*$/)[1] 7      end 8    end 9  end

{code}

Line 6 fails when "pip --version" returns other information:

{code:java} # pip --version

/usr/local/lib/python2.7/dist-packages/urllib3/contrib/socks.py:37: DependencyWarning: SOCKS support in urllib3 requires the installation of optional dependencies: specifically, PySocks.  For more information, see https://urllib3.readthedocs.io/en/latest/contrib.html#socks-proxies   DependencyWarning pip 1.5.6 from /usr/lib/python2.7/dist-packages (python 2.7)

{code}

Because then there is no match, it returns null and using [1] on null obviously fails. Installing python-pysocks removes the warning and fixes the puppet run.

*Desired Behavior:*

The pip_version function should be able to handle additional output. Either by checking if there is a match or by filtering out stderr.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper Fix Version/s: PUP 6.4.z Fix Version/s: PUP 5.5.z

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8986 Puppet agent crashes because of bug in pip provider

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment