Jira (PUP-8959) FastGettext.default_text_domain order dependent test failure

Josh Cooper (JIRA)

unread,

Jun 26, 2018, 5:18:05 PM6/26/18

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-8959

FastGettext.default_text_domain order dependent test failure

Change By:	Josh Cooper
Summary:	FastGetext FastGettext .default_text_domain appears to be unset order dependent test failure

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Thomas Hallgren (JIRA)

unread,

Jun 26, 2018, 6:13:03 PM6/26/18

to puppe...@googlegroups.com

Thomas Hallgren commented on

PUP-8959

Re: FastGettext.default_text_domain order dependent test failure

Josh Cooper I get the same error using that command on commit b811907. The parent commit cee544a however, succeeds without error. The culprit commit is part PR-6796 on ticket PUP-8672.

Add Comment

Michael Smith (JIRA)

unread,

Jun 27, 2018, 1:25:03 PM6/27/18

to puppe...@googlegroups.com

Michael Smith commented on

PUP-8959

Re: FastGettext.default_text_domain order dependent test failure

So maybe we need Puppet::GettextConfig.create_default_text_domain in the after(:each) block of those tests?

Add Comment

Michael Smith (JIRA)

unread,

Jun 27, 2018, 2:16:03 PM6/27/18

to puppe...@googlegroups.com

Michael Smith commented on

PUP-8959

Re: FastGettext.default_text_domain order dependent test failure

I can fix the particular failure Josh found. Trying to track down how the original failure happens because that code path should ensure there's a default text domain setup.