Jira (PDB-3928) Facts blacklist should support providing a fact name regex to blacklist facts matching a pattern

5 views
Skip to first unread message

Nick Walker (JIRA)

unread,
May 30, 2018, 4:32:04 PM5/30/18
to puppe...@googlegroups.com
Nick Walker created an issue
 
PuppetDB / Improvement PDB-3928
Facts blacklist should support providing a fact name regex to blacklist facts matching a pattern
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2018/05/30 1:31 PM
Priority: Normal Normal
Reporter: Nick Walker

The Problem

The puppet agent still sends legacy facts to the puppet master and they are forwarded onto PuppetDB. However, there's not many good reasons to store the legacy facts in addition to the modern structured facts.

Take a look at the list of legacy facts here: https://puppet.com/docs/facter/3.9/core_facts.html

Notice that alot of them include a network interface or something else unique which is bloating PuppetDB's fact storage full of unique facts. This makes lists of facts for populating things like autocomplete in the console UI larger and slower than they need to be.

Suggested Improvement

We already have a facts-blacklist in PuppetDB which could be used to workaround this problem if it allowed for a regex match on fact name so we could exclude facts like `mtu_` or `blockdevice_`

https://puppet.com/docs/puppetdb/5.1/configure.html#facts-blacklist

This isn't a full solution, really we should either stop sending legacy facts from the agent to the mater OR stop forwarding legacy facts from the master onto PuppetDB. Since those may have unintended consequences or may just be a breaking change, this improvement allows customers that want to take the initiative a way to remove these facts from being stored in PuppetDB.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Rob Browning (JIRA)

unread,
May 30, 2018, 4:44:03 PM5/30/18
to puppe...@googlegroups.com

Adam Bottchen (JIRA)

unread,
May 30, 2018, 4:47:04 PM5/30/18
to puppe...@googlegroups.com

Adam Bottchen (JIRA)

unread,
May 31, 2018, 7:23:02 PM5/31/18
to puppe...@googlegroups.com
Adam Bottchen updated an issue
Change By: Adam Bottchen
CS Priority: Needs Priority Major
CS Impact: There is a significant performance boost available for customers if they block unneeded facts from being sent for storage.  Without the ability to use regexs, it is not reasonable to blacklist all possible permutations of possible names for network and block device facts since they could be in the hundreds depending on installation size.  These are most likely not going to be needed by customers in general.
CS Severity: 4 - Major
CS Business Value: 4 - $$$$$
CS Frequency: 3 - 25-50% of Customers

Austin Boyd (JIRA)

unread,
Jun 11, 2018, 4:45:05 PM6/11/18
to puppe...@googlegroups.com

Austin Boyd (JIRA)

unread,
Jun 11, 2018, 4:45:06 PM6/11/18
to puppe...@googlegroups.com

Austin Boyd (JIRA)

unread,
Jun 11, 2018, 4:50:04 PM6/11/18
to puppe...@googlegroups.com
Austin Boyd updated an issue
Change By: Austin Boyd
Labels: jira_escalated
Zendesk Ticket IDs: 30378
Zendesk Ticket Count: 1

Zachary Kent (JIRA)

unread,
Jul 16, 2018, 6:16:02 PM7/16/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Jul 27, 2018, 12:19:03 PM7/27/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Aug 22, 2018, 1:53:04 PM8/22/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Sep 12, 2018, 9:29:02 AM9/12/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Sep 12, 2018, 7:45:04 PM9/12/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Sep 12, 2018, 7:56:04 PM9/12/18
to puppe...@googlegroups.com
Zachary Kent commented on Improvement PDB-3928
 
Re: Facts blacklist should support providing a fact name regex to blacklist facts matching a pattern

Kenn Hussey we ran into last minute complications with the release and this issue. As a result this will be making it into the next y or possibly a z. The fix version has been updated.

Nick Walker (JIRA)

unread,
Sep 26, 2018, 4:11:05 PM9/26/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Oct 18, 2018, 1:17:07 PM10/18/18
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Release Notes Summary:
Add support for fact blacklist regexes.  Omit facts whose name
completely matches any of the expressions provided.  Add a
"facts-blacklist-type" database configuration option which defaults to
"literal", producing the existing behavior, but can be set to "regex"
to indicate that the facts-blacklist items are java patterns.
Release Notes: New Feature

Zachary Kent (JIRA)

unread,
Oct 18, 2018, 1:17:08 PM10/18/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Oct 18, 2018, 1:20:07 PM10/18/18
to puppe...@googlegroups.com

Zachary Kent (JIRA)

unread,
Oct 22, 2018, 6:39:06 PM10/22/18
to puppe...@googlegroups.com

Joel Weierman (JIRA)

unread,
Oct 24, 2018, 9:20:02 AM10/24/18
to puppe...@googlegroups.com

Austin Boyd (JIRA)

unread,
Oct 22, 2019, 5:47:04 AM10/22/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages