Jira (FACT-1848) cmdline fact does not propperly resolve multiple parameters

[Doug Forster (JIRA)]

Doug Forster created an issue

Facter / FACT-1848 cmdline fact does not propperly resolve multiple parameters Issue Type: Bug Assignee: Unassigned Created: 2018/04/26 8:03 AM Priority: Normal Reporter: Doug Forster Currently facter doesn't properly parse cmdline fact. Given this command line: $ cat /proc/cmdline BOOT_IMAGE=/vmlinuz-3.10.0-693.11.1.el7.x86_64 root=/dev/mapper/vg_root-lv_root ro nofb splash=quiet crashkernel=auto rd.lvm.lv=vg_root/lv_root rd.lvm.lv=vg_root/lv_swap rhgb quiet LANG=en_US.UTF-8 This fact is generated: $ facter cmdline {{{}} {{ BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64",}} {{ root => "/dev/mapper/vg_root-lv_root",}} {{ ro => ,}} {{ nofb => ,}} {{ splash => "quiet",}} {{ crashkernel => "auto",}} {{ rd.lvm.lv => "vg_root/lv_swap",}} {{ rhgb => ,}} {{ quiet => ,}} {{ LANG => "en_US.UTF-8"}} } There are multiple rd.lvm.lv prameters but only the last is accounted for. It should be more like this: $ facter cmdline {{{}} {{ BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64",}} {{ root => "/dev/mapper/vg_root-lv_root",}} {{ ro => ,}} {{ nofb => ,}} {{ splash => "quiet",}} {{ crashkernel => "auto",}} {{ rd.lvm.lv => ["vg_root/{{lv_root}}", {{"vg_root/lv_swap"}}],}} {{ rhgb => ,}} {{ quiet => ,}} {{ LANG => "en_US.UTF-8"}} }     Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Doug Forster (JIRA)]

Doug Forster updated an issue

Facter / FACT-1848 cmdline fact does not propperly resolve multiple parameters

Change By: Doug Forster

Currently facter doesn't properly parse cmdline fact. Given this command line:

{code:java} # cat /proc/cmdline

BOOT_IMAGE=/vmlinuz-3.10.0-693.11.1.el7.x86_64 root=/dev/mapper/vg_root-lv_root ro nofb splash=quiet crashkernel=auto rd.lvm.lv=vg_root/lv_root rd.lvm.lv=vg_root/lv_swap rhgb quiet LANG=en_US.UTF-8

{code} This fact is generated: {code:java} # facter -p cmdline

{   BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64",   root => "/dev/mapper/vg_root-lv_root",   ro => ,   nofb => ,   splash => "quiet",   crashkernel => "auto",   rd.lvm.lv => "vg_root/lv_swap",   rhgb => ,   quiet => ,   LANG => "en_US.UTF-8" }

{code} {{}}

There are multiple rd.lvm.lv prameters but only the last is accounted for. It should be more like this:

{code:java} # facter -p cmdline

{   BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64",   root => "/dev/mapper/vg_root-lv_root",   ro => ,   nofb => ,   splash => "quiet",   crashkernel => "auto",

rd.lvm.lv => ["vg_root/lv_root", "vg_root/lv_swap"],

rhgb => ,   quiet => ,   LANG => "en_US.UTF-8" }

{code}

Add Comment

[Doug Forster (JIRA)]

Doug Forster updated an issue

Facter / FACT-1848 cmdline fact does not propperly resolve multiple parameters Change By: Doug Forster

Currently facter doesn't properly parse cmdline fact. Given this command line:

{ {$ code:java} # cat /proc/cmdline }}

{{ BOOT_IMAGE=/vmlinuz-3.10.0-693.11.1.el7.x86_64 root=/dev/mapper/vg_root-lv_root ro nofb splash=quiet crashkernel=auto rd.lvm.lv=vg_root/lv_root rd.lvm.lv=vg_root/lv_swap rhgb quiet LANG=en_US.UTF-8   {code } } This fact is generated:

{ {$ code:java} # facter -p cmdline }} { {{}}

{{   BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64", }} {{   root => "/dev/mapper/vg_root-lv_root", }} {{   ro => , }} {{   nofb => , }} {{   splash => "quiet", }} {{   crashkernel => "auto", }} {{   rd.lvm.lv => "vg_root/lv_swap", }} {{   rhgb => , }} {{   quiet => , }} {{   LANG => "en_US.UTF-8" } {code } {{}} } There are multiple rd.lvm.lv prameters but only the last is accounted for. It should be more like this:

{ {$ code:java} # facter -p cmdline }} { {{}}

{{ BOOT_IMAGE => "/vmlinuz-3.10.0-693.11.1.el7.x86_64", }} {{ root => "/dev/mapper/vg_root-lv_root", }} {{ ro => , }} {{ nofb => , }} {{ splash => "quiet", }} {{ crashkernel => "auto", }}

{{ rd.lvm.lv => ["vg_root/ {{ lv_root }} ", {{ "vg_root/lv_swap" }} ], }}

{{ rhgb => , }} {{ quiet => , }} {{ LANG => "en_US.UTF-8" } }   { { code } }}

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1848 cmdline fact does not propperly resolve multiple parameters

Change By: Scott McClellan Labels: linux triaged

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan commented on FACT-1848

Re: cmdline fact does not propperly resolve multiple parameters We will need to create a list of which kernel parameters should be treated this way.

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1848

cmdline fact does not propperly resolve multiple parameters

Change By: Branan Riley Labels: linux triaged

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1848 cmdline fact does not propperly resolve multiple parameters

Change By: Branan Riley Team: Platform OS

Add Comment

[Tim Meusel (Jira)]

Tim Meusel commented on FACT-1848

Re: cmdline fact does not propperly resolve multiple parameters Hi! I know the issue is quite old, sorry to bother you. I'm interested in a fact that parses /proc/cmdline. May I ask where this fact is coming from? As far as I know it's not a core fact on facter 3 nor facter 4.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)