Jira (PUP-8662) puppet plugin download doesn't re-use HTTP connections

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen created an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections Issue Type: Bug Affects Versions: PUP 5.5.0, PUP 4.10.10 Assignee: Unassigned Created: 2018/04/13 5:33 PM Priority: Normal Reporter: Charlie Sharpsteen The puppet plugin download command doesn't re-use connections to the Puppet Server when downloading plugins from modules. This adds considerable time to downloads along with extra load on the Puppet Server due to multiple redundant TLS handshakes. Reproduction Case Install puppet-agent 5.5.0 and puppetserver 5.3.0 on a CentOS 7 node: rpm -Uvh http://yum.puppetlabs.com/puppet5/puppet5-release-el-7.noarch.rpm yum install -y puppet-agent-5.5.0 puppetserver-5.3.0 Configure the puppet agent to connect to the local host and start puppetserver: /opt/puppetlabs/bin/puppet config set --section main server $(hostname -f) systemctl start puppetserver Run puppet agent -t to verify things work. Install the puppetlabs-windows module, which brings in a ton of plugins that will have to be synced: /opt/puppetlabs/bin/puppet module install puppetlabs-windows Empty the plugin cache, and time a puppet agent run along with the number of network connections it opens: rm -rf /opt/puppetlabs/puppet/cache/lib time /opt/puppetlabs/bin/puppet agent -t --http_debug 2>&1|grep -e Info: -e 'opening connection' Empty the cache again and time a puppet plugin download run along with the number of network connections opened: rm -rf /opt/puppetlabs/puppet/cache/lib time /opt/puppetlabs/bin/puppet plugin download --verbose --http_debug 2>&1|grep -e Info: -e 'opening connection' Outcome The puppet agent run uses a handful of connections: # rm -rf /opt/puppetlabs/puppet/cache/lib # time /opt/puppetlabs/bin/puppet agent -t --http_debug 2>&1|grep -e Info: -e 'opening connection'   opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... Info: Retrieving locales Info: Loading facts Info: Caching catalog for wzwhytp204ipraf.delivery.puppetlabs.net Info: Applying configuration version '1523665266'   real 0m43.990s user 0m16.685s sys 0m1.497s The puppet plugin download run uses hundreds of connections and takes much longer than the puppet agent run despite only doing a subset of the work: # rm -rf /opt/puppetlabs/puppet/cache/lib # time /opt/puppetlabs/bin/puppet plugin download --verbose --http_debug 2>&1|grep -e Info: -e 'opening connection'   Info: Retrieving pluginfacts opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... Info: Retrieving plugin opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... ... omitted hundreds of open calls for brevity ... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140... Info: Retrieving locales opening connection to wzwhytp204ipraf.delivery.puppetlabs.net:8140...   real 3m39.345s user 1m29.576s sys 0m2.405s Expected Outcome The puppet plugin download action should complete much faster than puppet agent -t when populating a cold plugin cache. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Charlie Sharpsteen Priority: Normal Major

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Team: Platform Core Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Fix Version/s: PUP 6.4.4 Fix Version/s: PUP 6.0.11 Fix Version/s: PUP 5.5.17

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8662

Re: puppet plugin download doesn't re-use HTTP connections The networking and ssl code is fragile prior to 6.4, so for those versions I've added a simple patch to fix puppet plugin download specifically. I'll file a separate ticket to delete the non-caching pool to avoid this kind of problem in the future, and same with the puppet device command. The reason I couldn't do that earlier, is we have to be careful about reusing connections with different SSL context/trust stores, and that's not possible in the older code.

Add Comment

[Kris Bosland (JIRA)]

Kris Bosland commented on PUP-8662

Re: puppet plugin download doesn't re-use HTTP connections

Merged to master at 0fd3f00.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8662

puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Release Notes Summary: puppet plugin download will reuse HTTPS connections significantly speeding up the download process. Release Notes: Bug Fix

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8662

Re: puppet plugin download doesn't re-use HTTP connections Passed master CI in a581f0ebb6

Add Comment

[Dorin Pleava (JIRA)]

Dorin Pleava updated an issue

Puppet / PUP-8662

puppet plugin download doesn't re-use HTTP connections

Change By: Dorin Pleava Fix Version/s: PUP 6.9.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Josh Cooper Fix Version/s: PUP 6.0.11

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-8662 puppet plugin download doesn't re-use HTTP connections

Change By: Jean Bond Labels: resolved-issue-added

Add Comment