Jira (PUP-8650) Repository error message uri is missing part of the path

[Tommy McNeely (JIRA)]

Tommy McNeely created an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path Issue Type: Bug Affects Versions: PUP 5.3.5 Assignee: Unassigned Created: 2018/04/09 2:43 PM Environment: CentOS 7.4, Puppet Enterprise 2017.3.5 (puppet-agent 5.3.5) Priority: Normal Reporter: Tommy McNeely We had a problem with our artifactory server, where it would return a 404 for the Puppet repository it was providing. This caused an error message to appear, about 404 errors. I tried to install the module manually (or search for it) and also got a 404 error: [root@puppetmaster ~]# puppet module --debug search saz-sudo Debug: Runtime environment: puppet_version=5.3.5, ruby_version=2.4.3, run_mode=user, default_encoding=UTF-8 Notice: Searching https://artifactory.domain.com/artifactory/api/puppet/puppet ... Debug: HTTP GET https://artifactory.domain.com/artifactory/api/puppet/puppet/artifactory/api/puppet/puppet/v3/modules?query=saz-sudo&module_groups=base%20pe_only Error: Request to Puppet Forge failed. The server being queried was https://artifactory.domain.com/v3/modules?query=saz-sudo&module_groups=base%20pe_only The HTTP response we received was '404 ' Error: Try 'puppet help module search' for usage   Before adding the debug flag, I thought that the puppet module tool was loosing the "path" part of the "module_repository" configuration when it read it from the puppet.conf, vs when it was specified on the command line. This was not the case, but it led to a lot of pointless troubleshooting. The error message should have the correct URL that failed.   NOTICE the difference between: Debug: HTTP GET https://artifactory.domain.com/artifactory/api/puppet/puppet/artifactory/api/puppet/puppet/v3/modules?query=saz-sudo&module_groups=base%20pe_only ... and: The server being queried was https://artifactory.domain.com/v3/modules?query=saz-sudo&module_groups=base%20pe_only   Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Tommy McNeely (JIRA)]

Tommy McNeely updated an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path

Note: Also affects 5.5.0 $ puppet module --debug --module_repository https://artifactory.domain.com/bogus_test/puppet/ search test Debug: Runtime environment: puppet_version=5.5.0, ruby_version=2.4.3, run_mode=user, default_encoding=UTF-8 Notice: Searching https://artifactory.domain.com/bogus_test/puppet/ ... Debug: Evicting cache entry for environment 'production' Debug: Caching environment 'production' (ttl = 0 sec) Debug: Failed to load library 'pe_license' for feature 'pe_license': cannot load such file -- pe_license Debug: HTTP GET https://artifactory.domain.com/bogus_test/puppet//bogus_test/puppet/v3/modules?query=test

Error: Request to Puppet Forge failed.

The server being queried was https://artifactory.domain.com/v3/modules?query=test The HTTP response we received was '404 Not Found'

Error: Try 'puppet help module search' for usage

... which I am sure was expected. I also thought that it was "chomp('/')" -ing the URL so it would not get a double "//" between the provided "module_repository" (baseurl) and the path. Change By: Tommy McNeely Affects Version/s: PUP 5.5.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path

Change By: Josh Cooper Team: Puppet Developer Experience

Add Comment

[Matthew (JIRA)]

Matthew commented on PUP-8650

Re: Repository error message uri is missing part of the path I can confirm this also effects 5.3.2 and 5.5.6. I upgraded my puppet enterprise trying to work around this issue. I also tried to mess with my Apache settings. This bug cost me at least 3 hours tonight.

Add Comment

[Caio Brandão do Amaral (JIRA)]

Caio Brandão do Amaral commented on PUP-8650

Re: Repository error message uri is missing part of the path

Just to document for people on legacy systems, like me. With Puppet 3.8 the problem is inverted, because the path of the URL given on module_repository is not used. So: Debug: HTTP GET https://...: contains the value from the configuration module_repository. The server being queried was https://...: contains the address actually used. This is probably the reason why this message is broken even nowadays.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650

Repository error message uri is missing part of the path

Change By: Josh Cooper Labels: beginner

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8650

Re: Repository error message uri is missing part of the path As of 6.16.0 the puppet module search action is deprecated, but the same problem exists when trying to install a module: bx puppet module --debug --module_repository https://artifactory.domain.com/bogus_test/puppet/ install nope/test Debug: Runtime environment: puppet_version=6.17.0, ruby_version=2.5.7, run_mode=user, default_encoding=UTF-8 Notice: Preparing to install into /Users/josh/.puppetlabs/etc/code/environments/production/modules ... Notice: Downloading from https://artifactory.domain.com/bogus_test/puppet/ ... Debug: HTTP GET https://artifactory.domain.com/bogus_test/puppet/v3/releases?module=nope-test&sort_by=version&exclude_fields=readme%2Cchangelog%2Clicense%2Curi%2Cmodule%2Ctags%2Csupported%2Cfile_size%2Cdownloads%2Ccreated_at%2Cupdated_at%2Cdeleted_at returned 404 Not Found Debug: Caching connection for https://artifactory.domain.com:443

Error: Request to Puppet Forge failed.

The server being queried was https://artifactory.domain.com/v3/releases?module=nope-test&sort_by=version&exclude_fields=readme,changelog,license,uri,module,tags,supported,file_size,downloads,created_at,updated_at,deleted_at

The HTTP response we received was '404 Not Found'

The double // issue mentioned above is fixed, but not the "The server being queried" error message. That would be a good beginner ticket.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650

Repository error message uri is missing part of the path

Change By: Josh Cooper Labels: beginner help_wanted

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-8650 Repository error message uri is missing part of the path

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path

Change By: Josh Cooper Team: Puppet Developer Experience Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650 Repository error message uri is missing part of the path

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8650

Re: Repository error message uri is missing part of the path Merged to 6.x in https://github.com/puppetlabs/puppet/commit/a5c79eb3b83d31235de38148e5cd6b469df689cb

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8650

Repository error message uri is missing part of the path

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: The "puppet module" application reported an incorrect URL in error messages if the "module_repository" setting was overridden.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8650

Re: Repository error message uri is missing part of the path Passed CI in a6087bd520

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-8650

Repository error message uri is missing part of the path

Change By: Claire Cadman Labels: beginner doc-reviewed help_wanted

Add Comment