Jira (PUP-8597) Modify rich data serialization to use shorter tags instead of __pcore_type__

[Henrik Lindberg (JIRA)]

Henrik Lindberg created an issue

Puppet / PUP-8597 Modify rich data serialization to use shorter tags instead of __pcore_type__ Issue Type: Improvement Assignee: Unassigned Created: 2018/03/23 7:31 AM Priority: Normal Reporter: Henrik Lindberg Serialization of rich data in JSON/YAML is currently using the tags: __pcore_type__ __pcore_value__ Those are longer than they need to be for making them unique/non-clashing with normal attributes. We should shorten those to: __ptype __pvalue When writing, but continue to support the longer tags when reading. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Henrik Lindberg (JIRA)]

Henrik Lindberg assigned an issue to Thomas Hallgren

Puppet / PUP-8597 Modify rich data serialization to use shorter tags instead of __pcore_type__

Change By: Henrik Lindberg Assignee: Thomas Hallgren

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8597 Modify rich data serialization to use shorter tags instead of __pcore_type__

Change By: Henrik Lindberg Release Notes Summary: The earlier rich data format used the tags __pcore_type__ and __pcore_value__, these are now shortened to __ptype and __pvalue respectively. Sprint: Platform Core KANBAN Release Notes: Deprecation Fix Version/s: PUP 6.0.0

Add Comment

[Rick Sherman (JIRA)]

Rick Sherman commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__ Heads up Thomas Honey and William Meek - this will affect our YANG modules.  If we want to support earlier versions of Puppet I suppose we'll have to support both names. cc Davin Hanlon lib/puppet/provider/ietf_interfaces/netconf.rb 86: if pcore.respond_to? :_pcore_type 92: elsif @property_hash[puppet_name.to_sym].respond_to? :_pcore_type   lib/puppet/provider/yang_ietf.rb 117: if k._pcore_type.instance_of? Puppet::Pops::Types::PObjectType 130: elsif k.instance_variable_get(i).respond_to? :_pcore_type 137: if k._pcore_type[i.to_s.tr('@','')].type.type.name == "Vanilla_ice::YangEmpty"

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Rick Sherman That code is not affected, that is the Pcore API - the change is just for the human readable serialization format where the tags before the change were _pcore_type and pcore_value_ - i.e. not the _pcore_type method on an object that returns its type. You would only have to change if you are reading or writing serializations of puppet objects using the human readable JSON serializer. Do you?

Add Comment

[Thomas Hallgren (JIRA)]

Thomas Hallgren commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Merged to master at e3723a0.

Add Comment

[Thomas Hallgren (JIRA)]

Thomas Hallgren assigned an issue to Unassigned

Puppet / PUP-8597

Modify rich data serialization to use shorter tags instead of __pcore_type__

Change By: Thomas Hallgren Assignee: Thomas Hallgren

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8597 Modify rich data serialization to use shorter tags instead of __pcore_type__

Change By: Henrik Lindberg Release Notes Summary: The earlier rich data experimental --rich_data format used the tags __pcore_type__ and __pcore_value__, these are now shortened to __ptype and __pvalue respectively. If you are using this experimental feature and have stored serializations you need to change them or write them again with the updated version.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__ Henrik Lindberg, Thomas Hallgren can you point me to the schema that describes the current pcore serialization format? /cc Rob Browning

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Davin Hanlon, Rick Sherman will this change break YANG modules? Do you know if there is a specification for pcore format?

Add Comment

[Davin Hanlon (JIRA)]

Davin Hanlon commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Josh Cooper - from Rick Sherman's earlier comment it looks like it will. However, the YANG modules are not released, so we can make changes before we release them to account for this. Does that seem OK Rick Sherman Thomas Honey?

Add Comment

[Rick Sherman (JIRA)]

Rick Sherman commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

We should be okay.  Those modules are still unreleased and we can update them if needed.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Thanks all. Is there a specification for the serialization format?

Add Comment

[Thomas Hallgren (JIRA)]

Thomas Hallgren commented on PUP-8597

Re: Modify rich data serialization to use shorter tags instead of __pcore_type__

Josh Cooper, I don't think any formal specification has been written yet. I created ticket PUP-9070.

Add Comment

[John Duarte (JIRA)]

John Duarte updated an issue

Puppet / PUP-8597

Modify rich data serialization to use shorter tags instead of __pcore_type__

Change By: John Duarte QA Risk Assessment: Needs Assessment No Action

Add Comment