Jira (FACT-1833) SSH host key without comment adds trailing newline

[Olav Morken (JIRA)]

Olav Morken created an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline Issue Type: Bug Affects Versions: FACT 3.10.0, FACT 3.6.9 Assignee: Unassigned Created: 2018/03/12 6:54 AM Priority: Normal Reporter: Olav Morken If the SSH host public key file does not contain a comment, the public key will contain a trailing newline. For example:   $ echo 'ssh-rsa public-key' >/etc/ssh/ssh_host_rsa_key.pub $ facter ssh {   rsa => {     key => "public-key "   } } {{}}   If the key contains a comment, we do not get the trailing newline:   $ echo 'ssh-rsa public-key comment' >/etc/ssh/ssh_host_rsa_key.pub $ facter ssh {{{}}   rsa => {     key => "public-key" {{  }}} }   The trailing newline causes issues when using the resulting fact directly in a sshkey resource, where the trailing newline makes Puppet think the resource is changed on every run. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Olav Morken (JIRA)]

Olav Morken updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Olav Morken

If the SSH host public key file does not contain a comment, the public key will contain a trailing newline. For example:

{noformat}

$ echo 'ssh-rsa public-key' >/etc/ssh/ssh_host_rsa_key.pub $ facter ssh {   rsa => {     key => "public-key "   }

}{noformat} {{}}

If the key contains a comment, we do not get the trailing newline:

{noformat} {noformat} {{ $ echo 'ssh-rsa public-key comment' >/etc/ssh/ssh_host_rsa_key.pub }}

{{ $ facter ssh }} { {{}} {{   rsa => { }} {{    key => "public-key" }} {{  } }}

} { { noformat } }}

The trailing newline causes issues when using the resulting fact directly in a sshkey resource, where the trailing newline makes Puppet think the resource is changed on every run.

Add Comment

[Olav Morken (JIRA)]

Olav Morken updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline Change By: Olav Morken

If the SSH host public key file does not contain a comment, the public key will contain a trailing newline. For example:   {noformat}$ echo 'ssh-rsa public-key' >/etc/ssh/ssh_host_rsa_key.pub $ facter ssh {   rsa => {     key => "public-key "   } }{noformat} If the key contains a comment, we do not get the trailing newline:

{noformat}$ echo 'ssh-rsa public-key comment' >/etc/ssh/ssh_host_rsa_key.pub

$ facter ssh {  rsa => {     key => "public-key"   } }{noformat} The trailing newline causes issues when using the resulting fact directly in a sshkey resource, where the trailing newline makes Puppet think the resource is changed on every run.

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Scott McClellan Team: Platform OS

Add Comment

[Scott McClellan (JIRA)]

Scott McClellan updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Scott McClellan Labels: triaged

Add Comment

[Brian McNally (JIRA)]

Brian McNally commented on FACT-1833

Re: SSH host key without comment adds trailing newline Thanks for such a clear description of this problem Olav. I've spent some time banging my head against the wall with this bug as well. Can we get this fixed, Puppet? This was reported over 18 months ago and still hasn't been assigned to anyone for fixing.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Facter / FACT-1833

SSH host key without comment adds trailing newline

Change By: Josh Cooper Team: Platform OS Night's Watch

Add Comment

[Austin Boyd (JIRA)]

Austin Boyd updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Austin Boyd Zendesk Ticket IDs: 35920 Zendesk Ticket Count: 1

Add Comment

[Mihai Buzgau (JIRA)]

Mihai Buzgau updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Mihai Buzgau Sprint: NW - 2020-03-03

Add Comment

[Mihai Buzgau (JIRA)]

Mihai Buzgau updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Mihai Buzgau Story Points: 2

Add Comment

[Ciprian Badescu (JIRA)]

Ciprian Badescu assigned an issue to Ciprian Badescu

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Ciprian Badescu Assignee: Ciprian Badescu

Add Comment

[Ciprian Badescu (JIRA)]

Ciprian Badescu updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Ciprian Badescu Release Notes Summary: correctly displays ssh host key fact in the case the host key file does no contain a comment Release Notes: Bug Fix

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Mihai Buzgau Fix Version/s: FACT 3.11.12

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-1833 SSH host key without comment adds trailing newline

Change By: Mihai Buzgau Fix Version/s: FACT 3.14.9

Add Comment