| Josh Cooper, the biggest problem with back-porting that rake task is that it's going to start failing CI runs, because of all of the existing issues in files on the older branches, whenever anyone changes anything. It can't differentiate between "this warning was introduced to this file in these changes", and "this warning already existed in the files affected by these changes". If we do back-port this check to the older branches, we're going to get a ton of failing CI runs because of all of the pre-existing issues that need to be cleaned up, or we'll need to spend the time to re-do all the clean-up work that I'd done before I set up the check on what was the master branch at the time. Were you expecting this ticket to also include the clean-up work? |