Jira (PUP-8535) Backport ruby warning rake task

2 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Mar 8, 2018, 2:20:03 PM3/8/18
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-8535
Backport ruby warning rake task
Issue Type: Task Task
Assignee: Unassigned
Created: 2018/03/08 11:19 AM
Fix Versions: PUP 5.3.x
Priority: Normal Normal
Reporter: Josh Cooper

We added a rake task to check for ruby warnings in puppet#master, but it doesn't catch issues that are merged into older branches and then merged up to master. It would be better to catch the issues at PR time.

This ticket is to backport the warnings rake task and update the travis CI matrix to execute the new check.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Mar 15, 2018, 7:16:03 PM3/15/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 5.3.x
Fix Version/s: PUP 5.3.6

Eric Delaney (JIRA)

unread,
Mar 22, 2018, 7:22:03 PM3/22/18
to puppe...@googlegroups.com
Eric Delaney assigned an issue to Eric Delaney
Change By: Eric Delaney
Assignee: Eric Delaney

Eric Delaney (JIRA)

unread,
Mar 22, 2018, 7:23:03 PM3/22/18
to puppe...@googlegroups.com
Eric Delaney updated an issue
Change By: Eric Delaney
Sprint: Platform Core Hopper KANBAN

Jacob Helwig (JIRA)

unread,
Mar 26, 2018, 12:49:06 PM3/26/18
to puppe...@googlegroups.com
Jacob Helwig assigned an issue to Jacob Helwig
Change By: Jacob Helwig
Assignee: Eric Delaney Jacob Helwig

Jacob Helwig (JIRA)

unread,
Mar 26, 2018, 12:54:14 PM3/26/18
to puppe...@googlegroups.com
Jacob Helwig commented on Task PUP-8535
 
Re: Backport ruby warning rake task

Josh Cooper, the biggest problem with back-porting that rake task is that it's going to start failing CI runs, because of all of the existing issues in files on the older branches, whenever anyone changes anything. It can't differentiate between "this warning was introduced to this file in these changes", and "this warning already existed in the files affected by these changes".

If we do back-port this check to the older branches, we're going to get a ton of failing CI runs because of all of the pre-existing issues that need to be cleaned up, or we'll need to spend the time to re-do all the clean-up work that I'd done before I set up the check on what was the master branch at the time.

Were you expecting this ticket to also include the clean-up work?

Enis Inan (JIRA)

unread,
Apr 9, 2018, 2:43:03 PM4/9/18
to puppe...@googlegroups.com
Enis Inan updated an issue
 
Change By: Enis Inan
Release Notes: Not Needed

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:53:03 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
Reply all
Reply to author
Forward
0 new messages