Jira (PUP-8519) Lexer errors with non existing Issues::HEREDOC_MISSING_ENDTAG

0 views
Skip to first unread message

Thomas Hallgren (JIRA)

unread,
Mar 8, 2018, 3:44:02 AM3/8/18
to puppe...@googlegroups.com
Thomas Hallgren created an issue
 
Puppet / New Feature PUP-8519
Lexer errors with non existing Issues::HEREDOC_MISSING_ENDTAG
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2018/03/08 12:43 AM
Priority: Normal Normal
Reporter: Thomas Hallgren

Given an expression such as:

@("")
 
This is heredoc $text
 
|-END

the lexer attempts to error with Issues::HEREDOC_MISSING_ENDTAG. Since there's no such issue, this instead results in a NameError. The correct issue to use here, given that there's no actual tag, would be Issues::HEREDOC_EMPTY_TAG.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Mar 8, 2018, 11:32:03 AM3/8/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 4.10.z

Henrik Lindberg (JIRA)

unread,
Mar 8, 2018, 11:33:02 AM3/8/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Sub-team: Language

Henrik Lindberg (JIRA)

unread,
Mar 8, 2018, 12:55:03 PM3/8/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 5.5.0

Henrik Lindberg (JIRA)

unread,
Mar 8, 2018, 12:55:06 PM3/8/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Issue Type: New Feature Bug

Henrik Lindberg (JIRA)

unread,
Mar 9, 2018, 5:17:03 AM3/9/18
to puppe...@googlegroups.com
Henrik Lindberg assigned an issue to Thomas Hallgren
Change By: Henrik Lindberg
Assignee: Thomas Hallgren

Henrik Lindberg (JIRA)

unread,
Mar 9, 2018, 5:19:02 AM3/9/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: If a heredoc used an empty endtag @("") it did not error the correct way and would report a Ruby NameError. Now the error correctly states that the error is raised because the end tag is empty.
Sprint: Platform Core KANBAN
Release Notes: Bug Fix
Fix Version/s: PUP 4.10.z

Thomas Hallgren (JIRA)

unread,
Mar 9, 2018, 6:16:02 AM3/9/18
to puppe...@googlegroups.com
Thomas Hallgren assigned an issue to Unassigned
Change By: Thomas Hallgren
Assignee: Thomas Hallgren

Thomas Hallgren (JIRA)

unread,
Mar 9, 2018, 6:16:05 AM3/9/18
to puppe...@googlegroups.com

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:54:03 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
 
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
Reply all
Reply to author
Forward
0 new messages