Jira (PUP-1460) Puppet hangs trying to replace a FIFO

20 views
Skip to first unread message

Stefan Pijnappels (JIRA)

unread,
Nov 10, 2016, 6:28:02 AM11/10/16
to puppe...@googlegroups.com
Stefan Pijnappels commented on Bug PUP-1460
 
Re: Puppet hangs trying to replace a FIFO

The puppet module build command also hangs indefinitely if a socket or FIFO is included in the /files directory of the module being built.
This appears to be the result of the command trying to copy an infinitely large file into the package.
A better solution would be for the command to either skip or error out if a socket or FIFO is encountered.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Nicholas Fagerlund (JIRA)

unread,
May 15, 2017, 4:35:03 PM5/15/17
to puppe...@googlegroups.com
Nicholas Fagerlund updated an issue
 
Puppet / Bug PUP-1460
Change By: Nicholas Fagerlund
Labels: redmine  triaged

Nicholas Fagerlund (JIRA)

unread,
May 15, 2017, 4:35:03 PM5/15/17
to puppe...@googlegroups.com
Nicholas Fagerlund updated an issue
Change By: Nicholas Fagerlund
Team: Agent

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:46:14 PM5/18/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: redmine  triaged

Josh Cooper (Jira)

unread,
Jan 26, 2021, 8:52:03 PM1/26/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Puppet does some stupid things trying to replace a FIFO, including opening it and trying to MD5 the content.

This allows a DoS for any managed file that can be replaced with a disconnected FIFO, at least.

To reproduce:
 <pre> {noformat}
mkfifo /tmp/boom
puppet apply &lt;&lt; << EOT
file { "/tmp/boom": ensure = &gt; > file, content = &gt; > "Hello, World" }
EOT
 </pre> {noformat}
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Oct 7, 2021, 5:24:02 AM10/7/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: NW - 2021-11-03
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Oct 7, 2021, 5:24:02 AM10/7/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Team: Coremunity Night's Watch

Ciprian Badescu (Jira)

unread,
Oct 18, 2021, 9:31:03 AM10/18/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: NW - 2021-11- 03 17

Ciprian Badescu (Jira)

unread,
Nov 3, 2021, 5:27:05 AM11/3/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Story Points: 2

Luchian Nemes (Jira)

unread,
Nov 16, 2021, 5:58:01 AM11/16/21
to puppe...@googlegroups.com
Luchian Nemes assigned an issue to Luchian Nemes
Change By: Luchian Nemes
Assignee: Luchian Nemes

Ciprian Badescu (Jira)

unread,
Nov 17, 2021, 4:14:03 AM11/17/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: NW - 2021-11-17 , NW - 2021-12-06

Josh Cooper (Jira)

unread,
Dec 1, 2021, 1:22:02 PM12/1/21
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Dec 1, 2021, 1:26:02 PM12/1/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-1460

Verified this works as expected:

$ mkfifo /tmp/boom
 
$ bx puppet apply <<EOT
 
file { "/tmp/boom": ensure => file, content => "Hello, World" }
 
EOT 
Notice: Compiled catalog for localhost in environment production in 0.01 seconds
 
Warning: /Stage[main]/Main/File[/tmp/boom]: Could not back up file of type fifo
 
Notice: /Stage[main]/Main/File[/tmp/boom]/ensure: defined content as '{md5}82bb413746aee42f89dea2b59614f9ef'
 
Notice: Applied catalog in 0.02 seconds
 
$ cat /tmp/boom 
Hello, World

Josh Cooper (Jira)

unread,
Dec 1, 2021, 1:28:02 PM12/1/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 6.26.0
Fix Version/s: PUP 7.13.0

Josh Cooper (Jira)

unread,
Dec 1, 2021, 1:28:03 PM12/1/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Bug Fix
Release Notes Summary: Puppet no longer hangs when trying to replace a fifo with a file, directory or symlink
Template: PUP Bug Template

Josh Cooper (Jira)

unread,
Dec 1, 2021, 1:29:03 PM12/1/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-1460
 
Re: Puppet hangs trying to replace a FIFO

Passed CI in 0fc096f07ecc1b4a36ae6eabe5716b3f03bd9c4e

Parker Leach (Jira)

unread,
Dec 8, 2021, 11:42:01 AM12/8/21
to puppe...@googlegroups.com
Parker Leach updated an issue
 
Change By: Parker Leach
Labels: docs_reviewed redmine
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages