Jira (FACT-1824) Facter includes offline cpus in processors::physicalcount

20 views
Skip to first unread message

Roland Sommer (JIRA)

unread,
Feb 22, 2018, 10:42:02 AM2/22/18
to puppe...@googlegroups.com
Roland Sommer created an issue
 
Facter / Bug FACT-1824
Facter includes offline cpus in processors::physicalcount
Issue Type: Bug Bug
Affects Versions: FACT 3.6.9
Assignee: Unassigned
Created: 2018/02/22 7:41 AM
Environment:

Linux debian jessie 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u2 (2016-10-19) x86_64 GNU/Linux

puppet-agent 1.10.10-1jessie

facter 3.6.9
Priority: Normal Normal
Reporter: Roland Sommer

Facter does count offline cpus as physical cpus in addition to the real sockets. To see this behaviour log on to a machine with 2 physical cpus and start disabling single logical cores like

echo "0" > /sys/devices/system/cpu/cpu19/online

With every disabled core, the physical cpu count reported by facter is incremented. This seems to be caused by the id.empty() condition in processor_resolver::compute_cpu_counts.

The code retrieves the id from .../topology/physical_package_id which is missing if a core is disabled, leading to an empty id.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Geoff Nichols (JIRA)

unread,
Mar 6, 2018, 5:12:02 PM3/6/18
to puppe...@googlegroups.com
Geoff Nichols updated an issue
Change By: Geoff Nichols
Team: Platform OS
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Geoff Nichols (JIRA)

unread,
Mar 6, 2018, 5:13:02 PM3/6/18
to puppe...@googlegroups.com
Geoff Nichols updated an issue
Change By: Geoff Nichols
Labels: debian linux triaged

Gheorghe Popescu (JIRA)

unread,
Nov 19, 2019, 2:53:04 AM11/19/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Team: Platform OS Night's Watch

Gheorghe Popescu (JIRA)

unread,
Nov 19, 2019, 2:54:04 AM11/19/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Sprint: PR - Triage

Gheorghe Popescu (JIRA)

unread,
Nov 27, 2019, 4:25:04 AM11/27/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Story Points: 3

Gheorghe Popescu (JIRA)

unread,
Nov 27, 2019, 5:04:04 AM11/27/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Sprint: PR 2019 - Triage 12-11

Dorin Pleava (JIRA)

unread,
Nov 29, 2019, 5:28:04 AM11/29/19
to puppe...@googlegroups.com
Dorin Pleava assigned an issue to Dorin Pleava
Change By: Dorin Pleava
Assignee: Dorin Pleava

Mihai Buzgau (JIRA)

unread,
Dec 11, 2019, 4:34:08 AM12/11/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: 2019-12-11 , 2019-12-24

Dorin Pleava (JIRA)

unread,
Dec 17, 2019, 2:45:04 AM12/17/19
to puppe...@googlegroups.com
Dorin Pleava updated an issue
Change By: Dorin Pleava
Release Notes Summary: Previous to this fix, facter wrongly reported disabled cpu cores as physical cpu cores. This was due to the way the folders structures modify when disabling a cpu core.
Now, facter correctly reports physical cpus, logical cpus, and ignoring disabled cpus.
Release Notes: Bug Fix

Dorin Pleava (JIRA)

unread,
Jan 8, 2020, 2:49:03 AM1/8/20
to puppe...@googlegroups.com
Dorin Pleava updated an issue
Change By: Dorin Pleava
Fix Version/s: FACT 3.11.11

Dorin Pleava (JIRA)

unread,
Jan 8, 2020, 9:45:04 AM1/8/20
to puppe...@googlegroups.com
Dorin Pleava updated an issue
Change By: Dorin Pleava
Fix Version/s: FACT 3.13.5

Jean Bond (JIRA)

unread,
Jan 14, 2020, 2:28:04 PM1/14/20
to puppe...@googlegroups.com
Jean Bond updated an issue
Change By: Jean Bond
Release Notes Summary: Previous to this fix, facter wrongly Facter incorrectly reported disabled cpu CPU cores as physical cpu CPU cores. This was due to the way the folders structures modify when disabling a cpu core.
 Now, facter Facter correctly reports physical cpus, and logical cpus, CPUs and ignoring ignores disabled cpus CPUs .

Jean Bond (JIRA)

unread,
Jan 14, 2020, 3:34:04 PM1/14/20
to puppe...@googlegroups.com
Jean Bond updated an issue
Change By: Jean Bond
Labels: debian linux resolved-issue-added

Mihai Buzgau (JIRA)

unread,
Jan 15, 2020, 5:39:04 AM1/15/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 3.14.7
Reply all
Reply to author
Forward
0 new messages