Jira (PUP-1357) Class names that match the node name are not evaluated

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PUP-1357

Re: Class names that match the node name are not evaluated Henrik Lindberg do you know if this is still a problem in pup latest? Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Moses Mendoza (JIRA)]

Moses Mendoza assigned an issue to Henrik Lindberg

Puppet / PUP-1357

Class names that match the node name are not evaluated

Change By: Moses Mendoza Assignee: Henrik Lindberg

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-1357

Re: Class names that match the node name are not evaluated Probably.

Add Comment

[Nicholas Fagerlund (JIRA)]

Nicholas Fagerlund updated an issue

Puppet / PUP-1357

Class names that match the node name are not evaluated

Change By: Nicholas Fagerlund Labels: redmine  triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Moses Mendoza Labels: redmine  triaged

Add Comment

[Tomáš Virtus]

Tomáš Virtus commented on PUP-1357

Re: Class names that match the node name are not evaluated Hello. I've just encountered the same problem with following open source components: puppet-agent 6.10.0-1buster puppetserver 6.7.0-1buster Does it work as designed? It took me some time to figure out that it could be related to node having same certificate name as class name. It'd be great to at least document the current behavior. I'm using Puppet to manage nodes on LAN without any domain and I have a module dedicated to certain node. I assumed that node and class names are different namespaces and therefore it wouldn't be a problem.

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-1357

Re: Class names that match the node name are not evaluated

It is certainly not by design - that would be really stupid. The reason this problem is not getting attention is probably because most use an external node classifier or hiera rather than the node expression.

Add Comment

[Rob Braden (JIRA)]

Rob Braden updated an issue

Puppet / PUP-1357

Class names that match the node name are not evaluated

Change By: Rob Braden Team: Server

Add Comment

[Rob Braden (JIRA)]

Rob Braden updated an issue

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Rob Braden Sub-team: Language

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Josh Cooper If I setup: {code:puppet} class subversion {   warning("I am class subversion") } {code} and in my nodes.pp I have {code} node subversion { include subversion } {code} When i run puppet in verbose mode on subversion, I never see that warning.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-1357

Re: Class names that match the node name are not evaluated I verified this issue still exists in 6.19.1, but does not occur when using an ENC. As Nick Lewis said, the node scope is set in https://github.com/puppetlabs/puppet/blob/5d6412cf5de9ed93d80439c539c1416ecf3216b2/lib/puppet/resource/type.rb#L237. And then later we see if a class scope with that name has already been added https://github.com/puppetlabs/puppet/blob/5d6412cf5de9ed93d80439c539c1416ecf3216b2/lib/puppet/parser/scope.rb#L420. And since there's already a node scope with that name, we skip including the class in https://github.com/puppetlabs/puppet/blob/5d6412cf5de9ed93d80439c539c1416ecf3216b2/lib/puppet/parser/compiler.rb#L308-L313

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-1357

Class names that match the node name are not evaluated

Change By: Josh Cooper Team: Froyo Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Josh Cooper Assignee: Henrik Lindberg Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-1357 Class names that match the node name are not evaluated

Change By: Josh Cooper Fix Version/s: PUP 6.21.0 Fix Version/s: PUP 7.4.0

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on PUP-1357

Re: Class names that match the node name are not evaluated Josh Cooper, will this get into ** PUP 7.4.0, PUP 6.21.0  ?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-1357

Class names that match the node name are not evaluated

Change By: Josh Cooper Fix Version/s: PUP 6.21.0 Fix Version/s: PUP 7.4.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-1357

Re: Class names that match the node name are not evaluated I removed the fix versions, and we can fix in the next set of .z releases. It's been broken for a long time, and as Henrik mentioned most people use an ENC.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-1357

Re: Class names that match the node name are not evaluated

Puppet currently stores node and class scopes in a hash in top scope. It's currently possible for node and class scopes to collide, where the latter can overwrite the latter, but relying on that behavior to solve this problem seems like a bad idea. I'm going to close this in favor of PUP-3995 which will add an error if a class is, ignored because of a conflict with a node definition. Note using a regex or the default bareword doesn't have this problem.

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)