Jira (PUP-8243) Allow ERB templates to be tolerant of a leading BOM

[Ethan Brown (JIRA)]

Ethan Brown created an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM Issue Type: Improvement Assignee: Unassigned Created: 2017/12/12 7:39 AM Labels: windows utf-8 Priority: Normal Reporter: Ethan Brown See additional details in MODULES-1996 / PUP-6447. The basic gist is that internal calls to read, like the one made by template loading with Puppet::FileSystem.read_preserve_line_endings, do not specify the "allow bom" flag when reading UTF-8 files. This should be a straightforward addition that allows templates (for instance PowerShell templates that were once PS1 files created by PowerShell ISE that have a leading BOM) to properly remove the leading BOM. Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Ethan Brown Priority: Normal Major

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Craig Gomes Sprint: Windows  Hopper  Grooming

Add Comment

[Erick Banks (JIRA)]

Erick Banks updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Erick Banks Sprint: Windows Grooming

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Josh Cooper Team: Windows Night's Watch

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Josh Cooper Team: Night's Watch Coremunity

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8243

Re: Allow ERB templates to be tolerant of a leading BOM Merged to 6.x in https://github.com/puppetlabs/puppet/commit/a557077b29450bc05f1c5d647c10ce9936580f54

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8243

Re: Allow ERB templates to be tolerant of a leading BOM

Passed CI in cb46c5176a

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8243

Allow ERB templates to be tolerant of a leading BOM

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Gabriel Nagy Release Notes: Enhancement Release Notes Summary: Previously, if a template contained a BOM, then it was preserved by the `template` function, and would end up in the resulting file or PowerShell command. Now we pass the `bom` option when reading the file, which strips the BOM as it is read.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-8243 Allow ERB templates to be tolerant of a leading BOM

Change By: Claire Cadman Labels: doc-reviewed utf-8 windows

Add Comment